Fix epochs schema to resolve double nesting of sdpi:Epoch element.#521
Open
PaulMartinsen wants to merge 3 commits intomasterfrom
Open
Fix epochs schema to resolve double nesting of sdpi:Epoch element.#521PaulMartinsen wants to merge 3 commits intomasterfrom
sdpi:Epoch element.#521PaulMartinsen wants to merge 3 commits intomasterfrom
Conversation
…ma-because-of-sdpiepochs
…first epoch before any abrupt adjustments are required.
| <!----> | ||
| <!--Epochs--> | ||
| <xsd:element name="Epochs"> | ||
| <xsd:element name="Epochs" type="sdpi:EpochsType"> |
Collaborator
There was a problem hiding this comment.
I suppose, this is a BICEPS extensions, isn't it? It lacks the necessary MustUnderstand attribute then.
It is recommended to add the optional attribute to the element that represents the extension rather than adding it to the type. That would result in "Epochs" being:
<xsd:element name="Epochs">
<xsd:complexType>
<xsd:complexContent>
<xsd:extension base="sdpi:EpochsType">
<xsd:attribute ref="ext:MustUnderstand" use="optional" />
</xsd:extension>
</xsd:complexContent>
</xsd:complexType>
</xsd:element>
d-gregorczyk
requested changes
Apr 21, 2026
Collaborator
d-gregorczyk
left a comment
d-gregorczyk
left a comment
There was a problem hiding this comment.
Found another one; sorry for the late review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📑 Description
Resolves
TimeStampVersion.xsdschema bug in #520 to avoid nestingsdpi:Epochfound by Leon.☑ Mandatory Tasks
The following aspects have been respected by the pull request assignee and at least one reviewer: