WIP: ADA Hackathon 2020, ORB_SLAM3 as an ILLIXR plugin.#1
Open
Alkaid-Benetnash wants to merge 2 commits into
Open
WIP: ADA Hackathon 2020, ORB_SLAM3 as an ILLIXR plugin.#1Alkaid-Benetnash wants to merge 2 commits into
Alkaid-Benetnash wants to merge 2 commits into
Conversation
…arget plugin.so but does not conform with ILLIXR interface.
Comment on lines
+239
to
+248
| cv::Mat Rwc = Tcw.rowRange(0, 3).colRange(0, 3).t(); | ||
| cv::Mat twc = -Rwc * Tcw.rowRange(0, 3).col(3); | ||
| Eigen::Vector3f position{twc.at<float>(0), twc.at<float>(1), | ||
| twc.at<float>(2)}; | ||
| Eigen::Matrix3f emat3f; | ||
| cv2eigen(Rwc, emat3f); | ||
| Eigen::Quaternionf orientation(emat3f); | ||
| _m_pose->put(new pose_type{.sensor_time = imu_cam_buffer->time, | ||
| .position = position, | ||
| .orientation = orientation}); |
Author
There was a problem hiding this comment.
This pose convertion part is wrong.
You need to figure out how ORB_SLAM3 encode poses.
This might be helpful but I failed to understand.
raulmur/ORB_SLAM2#428
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Did not test correctness.
Need to sym-link
ILLIXR/commontoORB_SLAM3/ILLIXR_common.Current
CMakeFiles.txtcan compile a .so target plugin.so, but it does not conform with ILLIXR plugin build scripts interfaces.