Ashton Martin by AshtonMar · Pull Request #45 · IMQS/onboard-javascript

AshtonMar · 2022-04-12T13:18:26Z

Onboarding JS Project

anzelIMQS · 2022-04-28T08:07:06Z

app.ts

+      } else {
+        //pass
+      }


Remove the else

anzelIMQS · 2022-04-28T08:07:17Z

app.ts

+        } else {
+          //pass
+        }


Remove the else

anzelIMQS · 2022-04-28T08:07:55Z

app.ts

+      } else {
+        //pass
+      }


Remove the else

anzelIMQS · 2022-04-28T08:08:15Z

app.ts

+      } else {
+        //pass
+      }


Remove the else.

anzelIMQS · 2022-04-28T08:08:28Z

app.ts

+      } else {
+        //pass
+      }


Remove the else.

anzelIMQS · 2022-04-28T08:08:37Z

app.ts

+      } else {
+        //pass
+      }


Remove the else.

anzelIMQS · 2022-04-28T08:09:18Z

app.ts

+  let fromNumber: any;
+  let toNumber: any;
+  let recordDiff: any;


Don't use any if not necessary. Give them a specific type.

anzelIMQS · 2022-04-28T08:09:48Z

app.ts

+    headers: { "Content-Type": "application/json" },
+  })
+    .then((response) => response.text())
+    .then((data) => {


Add a catch to log and handle errors.

anzelIMQS · 2022-04-28T08:10:05Z

app.ts

+    }
+  )
+    .then((response) => response.text())
+    .then((data) => {


Add a catch to log and handle errors.

anzelIMQS · 2022-04-28T08:10:38Z

server/main.go


+var columns = [13]string{"ID", "A", "B", "C", "D", "E", "F", "G", "H", "I", "J", "K", "L"}
 const recordCount = 1000000
-const columnCount = 11
+const columnCount = len(columns); 
 const delayResponse = 500 * time.Millisecond

-var columns = [columnCount]string{"ID", "A", "B", "C", "D", "E", "F", "G", "H", "I", "J"}
 var letters = []rune("abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ")


Don't touch the backend. Frontend only.

geraldtivatyi · 2022-04-28T10:13:50Z

app.ts

@@ -0,0 +1,414 @@
+// Get the container from the html where the data will be stored
+let recordNav: any = document.querySelector("#record-navigation-container"); //Navigation area;


These do not need to be global variables. Global variables are generally frowned upon. There are a few acceptable global variables but try to remove these from being global.

geraldtivatyi · 2022-04-28T10:18:23Z

app.ts

+}
+
+// The functionality to move through an amount of records.
+function nextPrevious(firstId: any) {


Use the any type sparingly. Go through the JavaScript Style Guide to see preferences and standards.

geraldtivatyi · 2022-04-28T10:20:50Z

app.ts

+      let amountRecord: any;
+
+      if (finalId >= 999999) {
+        if (window.innerHeight > 500) {


I would avoid doing this check.Try to fit as much readable rows on the screen as possible. Screen sizes will vary so rather try to have a function that calculates and returns the number of rows you can fit on the page and then use that value to set your parameters for fetching the table data.

geraldtivatyi · 2022-04-28T10:22:43Z

app.ts

+          finalId = 999999;
+          firstId = finalId - 2;
+        } else if (window.innerHeight <= 170) {
+          finalId = 999999;


finalId is being repeated multiple times in the if statements. This is a good sign to either create a method or just simply move that line outside of the if-else statements. Code refactoring basically :P

geraldtivatyi · 2022-04-28T10:23:05Z

app.ts

+      } else {
+        if (window.innerHeight > 500) {
+          amountRecord = 14;
+          finalId = firstId + amountRecord;


Some more repetitive code here.

geraldtivatyi · 2022-04-28T10:24:52Z

app.ts

+          (finalId - firstId + 1) +
+          " records only.";
+
+        console.log(typeof firstId, typeof finalId);


I'm guessing this was for testing your code? You can remove any console.logs if they are not necessary.

geraldtivatyi · 2022-04-28T10:27:57Z

app.ts

+
+      finalId = 999999;
+
+      if (window.innerHeight > 500) {


This checking for the screen size is being done for a second time (similar to earlier in the nextPrevious() function), so I think put this logic into its own method which you can call when you need to know whats the number of rows needed for the current screen size.

geraldtivatyi · 2022-04-28T10:30:22Z

app.ts

+  }
+
+  let resizeScreen = () => {
+    if (window.innerHeight > 500) {


This window size check is repeated here again.

CelesteNaude · 2022-04-28T11:11:40Z

index.html

+    <div id="record-navigation-container"></div>
+    <div id="column-headings-container"></div>
+    <div id="info-columns-container"></div>
+    <script src="./app.js"></script>


Please move your script to the head tag.

CelesteNaude · 2022-04-28T11:15:25Z

index.html

+    <script
+      type="text/javascript"
+      charset="utf-8"
+      src="third_party/jquery-2.0.3.min.js"
+    ></script>


Rather keep this to one line.

Suggested change

<script

type="text/javascript"

charset="utf-8"

src="third_party/jquery-2.0.3.min.js"

></script>

<script type="text/javascript" charset="utf-8" src="third_party/jquery-2.0.3.min.js"></script>

CelesteNaude · 2022-04-28T11:18:57Z

app.ts

+let recordNav: any = document.querySelector("#record-navigation-container"); //Navigation area;
+let headingColumns: any = document.querySelector("#column-headings-container"); //Headings;
+let infoColumns: any = document.querySelector("#info-columns-container"); //Information;


Don't use global variables, rather move them to a class (denounce is fine tho).

CelesteNaude · 2022-04-28T11:39:46Z

app.ts

+      if (firstId === 0) {
+        previousBtn.disabled = true;
+        nextBtn.disabled = false;
+      } else if (finalId === 999999) {
+        nextBtn.disabled = true;
+        previousBtn.disabled = false;


Don't use hard coded values (i.e. 0 and 999999) to do checks on your ids. What would happen if a data set of a different size is given? Try to keep checks on your data as generic as possible.

anzelIMQS

Just a few more little changes.

anzelIMQS · 2022-05-03T06:34:09Z

app.ts

+        firstId = firstId;
+        finalId = finalId;


It surely shouldn't be necessary to set these variables to themselves? Especially since they are global variables in your case.

anzelIMQS · 2022-05-03T06:39:39Z

app.ts

+        currentPage.innerHTML =
+          firstId +
+          " / " +
+          finalId +
+          " " +
+          (finalId - firstId + 1) +
+          " records only.";


Please rather make use of template literals here.

It's better suited for string concatenation when you have more than 1 variable in your string.

anzelIMQS

Do check some of the comments I made and see if they are applicable somewhere else where I might have missed them.

Please do ask me if something is unclear in what I said.

anzelIMQS · 2022-05-03T08:25:49Z

app.ts

+      headers: { "Content-Type": "application/json" },
+    })
+      .then((response) => response.text())
+      .then((data) => {


Implement the catch on the Promise. .then().catch( () => {});

anzelIMQS · 2022-05-03T08:26:24Z

app.ts

+let tryCatch = (func: any) => {
+  try {
+    func;
+  } catch (error) {
+    console.log(error);
+  }
+};


Let's not do it this way but rather on the Promise.

anzelIMQS · 2022-05-03T08:27:05Z

server/main.go


 const recordCount = 1000000
-const columnCount = 11
+const columnCount = 11 


Remove the whitespace

anzelIMQS · 2022-05-03T08:29:12Z

app.ts

+
+function recordSelection() {
+  let selectionArea: any = document.querySelector("#record-navigation-container");
+  let SingleRecordSelection = `


Please make it lowerCamelCase

anzelIMQS · 2022-05-03T08:31:44Z

app.ts

+    currentPage.innerHTML = "";
+    currentPage.innerHTML = currentPage.innerHTML = fromNumber + " / " + toNumber + " " + (Number(numberOfRows) + 1) + " records only.";


No need to clear it. If you set it a value, the previous values are overwritten.

anzelIMQS · 2022-05-03T09:54:29Z

app.ts

+
+let nextPrevious = (fromNumber: number) => {
+  let numberOfRows = Math.floor(window.innerHeight / 50);
+  let count: number = 0;


Remove count. No need to multiply. The next function is supposed to be executed every time it passes debouncing.

anzelIMQS · 2022-05-03T09:54:31Z

app.ts

+  }
+}
+
+let nextPrevious = (fromNumber: number) => {


Probably give this function a more descriptive name

anzelIMQS · 2022-05-03T09:54:54Z

app.ts

+  previousPage = debounce(previousPage, 500);
+  previousBtn.addEventListener("click", () => {
+    count++;
+    previousPage();
+  });


Pass in directly.

anzelIMQS · 2022-05-03T09:56:19Z

app.ts

+  nextPage = debounce(nextPage, 500);
+  nextBtn.addEventListener("click", () => {
+    count++;
+    nextPage();
+  });


Pass in directly

anzelIMQS · 2022-05-03T09:57:51Z

app.ts

+let headingColumns: any = document.querySelector("#column-headings-container"); //Headings;
+let infoColumns: any = document.querySelector("#info-columns-container"); //Information;


Add whitespace between // and comment. Can probably remove the semi-colon as well.

anzelIMQS

Make sure to make use of the API recordCount. Also, remove some redundancy.

anzelIMQS · 2022-05-05T08:19:25Z

app.ts

+};
+
+lastPageBtn.addEventListener("click", () => {
+  console.log("Hello");


Remove fancy logging

anzelIMQS · 2022-05-05T08:20:49Z

app.ts

+};
+
+function getRecords(fromNumber: number, toNumber: number) {
+  fetch("http://localhost:2050/records?from=" + fromNumber + "&to=" + toNumber, {


Let's make this Template literals.

anzelIMQS · 2022-05-05T08:21:22Z

app.ts

+    } else if (typeof fromNumber === "number" && fromNumber >= 0) {
+      getRecords(fromNumber, toNumber);
+    } else {
+      alert("Error");


Tell me what's wrong? Error what?

anzelIMQS · 2022-05-05T08:22:31Z

app.ts

+  selectionArea.innerHTML = "";
+  selectionArea.innerHTML = singleRecordSelection;


Probably not necessary to clear it since you are anyway assigning it a new value that overwrites the previous one?

anzelIMQS · 2022-05-05T08:32:58Z

app.ts

+    nextBtn.disabled = false;
+    previousBtn.disabled = false;
+
+    if (fromNumber + numberOfRows >= 999999) {


I only noticed now you are working on a hardcoded value for the max recordCount (999999). Please ask the API once for that value and store it. You can then use it accordingly instead of the working of a hardcoded values.

anzelIMQS · 2022-05-05T08:34:46Z

server/main.go

 const columnCount = 11
 const delayResponse = 500 * time.Millisecond
-
 var columns = [columnCount]string{"ID", "A", "B", "C", "D", "E", "F", "G", "H", "I", "J"}


There should be any changes to this file. Looks like you accidentally removed the new lines. Make sure this file doesn't even popup on Files changed on GitHub.

FritzOnFire

Please convert your spaces into tabs.

Please remove the text file from the PR.

Please remove all the any types. The only place I know of that you would need an any is when getting data from the back-end, but most people just specify the actual type there anyway.

You have a lot of global variables and logic being executed in global scope. Please move them into a class, or somewhere where they are no longer considered to be global. (Hint, the class option will ensure that you get way less future review changes)

FritzOnFire · 2022-05-06T06:39:25Z

app.ts

+let headingColumns: any = document.querySelector("#column-headings-container"); // Headings
+let infoColumns: any = document.querySelector("#info-columns-container"); // Information


The way your code is written these lines will execute before those elements actually exist on the webpage. So they can definitely not be here. You should only try and get things from the webpage after it has been rendered.

Also change the any to the actual type.

FritzOnFire · 2022-05-06T06:42:04Z

server/main.go

 	"strconv"
 	"time"
 )
-


This file should not show up in this PR.

FritzOnFire · 2022-05-06T06:43:53Z

app.ts

+    <button value="previous" class="previous-records-btn">Previous</button>
+    <button value="next" class="next-records-btn">Next</button>
+    <button value="last" class="last-page-btn">Last Page</button>  
+    <button onclick="recordSelection()" id="confirmation-btn">Get Record</button>


You should not specify your onclick in the HTML. You should do it in the typescript code.

FritzOnFire · 2022-05-06T06:44:34Z

app.ts

+  };
+};
+
+let createNavigation = () => {


Please change this variable to a normal function, seeing as that you never override the value.

FritzOnFire · 2022-05-06T06:47:39Z

app.ts

+            type="text"
+            min="0"
+            minlength="1"
+            maxlength="6"


Hardcoding the max length here is a bad idea, as the maximum amount of rows that you could get is unknown.

FritzOnFire · 2022-05-06T07:01:18Z

app.ts

+      }
+      resizeScreenData();
+    })
+    .catch((error) => {


Please remove the () around the error parameter or specify the type, as the compiler currently thinks it is of type any.

FritzOnFire · 2022-05-06T07:05:02Z

app.ts

+};
+
+function getRecords(fromNumber: number, toNumber: number) {
+  fetch(`http://localhost:2050/records?from=${fromNumber}&to=${toNumber}`, {


You should add a return in front of your fetch to allow other functions to wait on this function.

FritzOnFire · 2022-05-06T07:05:22Z

app.ts

+    .then((response) => response.text())
+    .then((data) => {


Please remove the () around the parameters or specify the types, as the compiler currently thinks they are of type any.

FritzOnFire · 2022-05-06T07:05:37Z

app.ts

+    method: "GET",
+    headers: { "Content-Type": "application/json" },
+  })
+    .then((response) => response.text())


You should check if response has an error here.

FritzOnFire · 2022-05-06T07:06:02Z

app.ts

+      let currentPage: any = document.querySelector(".current-page");
+      currentPage.innerHTML = `${fromNumber}  / ${toNumber}.`;
+    })
+    .catch((error) => {


Please remove the () around the error parameter or specify the type, as the compiler currently thinks it is of type any.

FritzOnFire

Please change the spaces to tabs.

FritzOnFire · 2022-05-09T07:43:46Z

app.ts

+    fromNumber = 0;
+};
+
+function checkResponseError(response: Response) {


Please specify a return type.

FritzOnFire · 2022-05-09T07:44:12Z

app.ts

+    }
+}
+
+function getRecords(fromNumber: number, toNumber: number) {


Please specify a return type

FritzOnFire · 2022-05-09T07:45:10Z

app.ts

+        headers: { "Content-Type": "application/json" },
+    })
+        .then(checkResponseError)
+        .then((response: Response) => response.text())


You should rather use .json(). Then you don't have to parse the result and check if it successfully parsed in the next section.

FritzOnFire · 2022-05-09T07:45:42Z

app.ts

+    })
+        .then(checkResponseError)
+        .then((response: Response) => response.text())
+        .then((data) => {


Either remove the () or specify the type, as the compiler currently thinks the type is any.

FritzOnFire · 2022-05-09T07:47:44Z

app.ts

+            let infoColumns: HTMLElement | null = document.getElementById("info-columns-container"); // Information
+
+            console.log("Hello");
+            (infoColumns as HTMLDivElement).innerHTML = "";


You need to check if infoColumns is null, and handle it appropriately. Instead of hard casting the value.

FritzOnFire · 2022-05-09T08:28:52Z

app.ts

+    let nextBtn: HTMLElement | null = document.getElementById("next-records-btn");
+    let previousBtn: HTMLElement | null = document.getElementById("previous-records-btn");
+    let navBtns = document.getElementById("navigation-btns");
+    if (recordNav !== null) {


You should probably error or something if this happens, otherwise the user will not know whats wrong.

FritzOnFire · 2022-05-09T08:29:17Z

app.ts

+            (nextBtn as HTMLButtonElement).disabled = false;
+            (previousBtn as HTMLButtonElement).disabled = false;


You should check for nulls.

FritzOnFire · 2022-05-09T08:32:52Z

app.ts

+recordCount();
+window?.addEventListener("resize", debounce(resizeScreenData, 500));
+createNavigation();
+headingRowCreation();
+
+{
+    let confirmationBtn: HTMLElement | null = document.getElementById("confirmation-btn");
+    confirmationBtn?.addEventListener("click", recordSelection);
+
+    let nextBtn: HTMLElement | null = document.getElementById("next-records-btn");
+    let previousBtn: HTMLElement | null = document.getElementById("previous-records-btn");
+    let firstPageBtn: HTMLElement | null = document.getElementById("first-page-btn");
+    let lastPageBtn: HTMLElement | null = document.getElementById("last-page-btn");
+
+    let nextPage = () => {
+        console.log(fromNumber);
+        let numberOfRows = Math.floor(window.innerHeight / 50);
+        fromNumber = fromNumber + numberOfRows * count;
+        let toNumber = fromNumber + numberOfRows;
+
+        let finalRecord = recordNumberTotal - 1;
+
+        (previousBtn as HTMLButtonElement).disabled = false;
+
+        if (toNumber >= finalRecord) {
+            (nextBtn as HTMLButtonElement).disabled = true;
+            fromNumber = finalRecord - numberOfRows;
+        }
+
+        getRecords(fromNumber, toNumber);
+        count = 0;
+    };
+    nextBtn?.addEventListener("click", () => {
+        count++;
+        nextPage = debounce(nextPage, 500);
+        nextPage();
+    });
+
+    let previousPage = () => {
+        let numberOfRows = Math.floor(window.innerHeight / 50);
+        fromNumber = fromNumber - numberOfRows * count;
+        let toNumber = fromNumber + numberOfRows;
+        (nextBtn as HTMLButtonElement).disabled = false;
+
+        if (fromNumber <= 0) {
+            (previousBtn as HTMLButtonElement).disabled = true;
+            fromNumber = 0;
+        }
+
+        getRecords(fromNumber, toNumber);
+        count = 0;
+    };
+    previousBtn?.addEventListener("click", () => {
+        count++;
+        previousPage = debounce(previousPage, 500);
+        previousPage();
+    });
+
+    let firstPage = () => {
+        fromNumber = 0;
+        let numberOfRows = Math.floor(window.innerHeight / 50);
+        let toNumber = fromNumber + numberOfRows;
+        (nextBtn as HTMLButtonElement).disabled = false;
+        (previousBtn as HTMLButtonElement).disabled = true;
+
+        getRecords(fromNumber, toNumber);
+    };
+    firstPageBtn?.addEventListener("click", () => {
+        firstPage();
+    });
+
+    let lastPage = () => {
+        let finalRecord = recordNumberTotal - 1;
+        let numberOfRows = Math.floor(window.innerHeight / 50);
+        fromNumber = finalRecord - numberOfRows;
+        (nextBtn as HTMLButtonElement).disabled = true;
+        (previousBtn as HTMLButtonElement).disabled = false;
+
+        getRecords(fromNumber, finalRecord);
+    };
+    lastPageBtn?.addEventListener("click", () => {
+        lastPage();
+    });
+}


This is to much logic happening in global space, please either move it into a class, or have it executed somewhere else.

FritzOnFire · 2022-05-09T08:33:59Z

index.html

+    <title>JS Onboard Project</title>
+    <script type="text/javascript" charset="utf-8" src="third_party/jquery-2.0.3.min.js"></script>
+    <link rel="stylesheet" href="./style.css" />
+    <script src="./app.js" defer></script>


You should not really be using defer for this project... but there aren't any rules against it, so I can't ask you to remove it.

FritzOnFire · 2022-05-09T08:34:19Z

server/main.go

 	"strconv"
 	"time"
 )
-


FritzOnFire

debounces or throttles may not exceed 250ms, ideally the closer to 50ms the better. Please change yours, 500ms is way to much.

FritzOnFire · 2022-05-11T11:04:00Z

app.ts

+	return response;
+}
+
+function debounce(func: any, delay: number) {


Please specify the type of func. Im pretty sure it should be () => void.

FritzOnFire · 2022-05-11T11:05:41Z

app.ts

+	})
+		.then(checkResponseError)
+		.then((response: Response) => response.json())
+		.then((data: string) => {


Not sure how this is a string, and then a few lines down you have a for-loop over it?

FritzOnFire · 2022-05-11T11:06:46Z

app.ts

+	createNavigation();
+	recordCount();
+	headingRowCreation();
+	fromNumber = 0;
+	new pageNavigation();


You should create the functions and classes before you use them (They should appear before the window.onload line)

FritzOnFire · 2022-05-11T11:08:31Z

app.ts

+			let currentPage: HTMLElement | null = document.getElementById("current-page");
+
+			if (infoColumns !== null) {
+				(infoColumns as HTMLDivElement).innerHTML = "";


You don't have to hard cast to HTMLDivElement if you have checked for the null. Please remove it.

FritzOnFire · 2022-05-11T11:09:38Z

app.ts

+			}
+
+			if (currentPage !== null) {
+				(currentPage as HTMLParagraphElement).innerHTML = `${fromNumber}  / ${toNumber}.`;


Same as the comment before, please remove the hard cast.

FritzOnFire · 2022-05-11T11:35:37Z

app.ts

+				(this.nextBtn as HTMLButtonElement).disabled = true;
+				(this.previousBtn as HTMLButtonElement).disabled = false;


Same as previous comment about these two buttons.

FritzOnFire · 2022-05-11T11:36:07Z

index.html

+    <script
+      type="text/javascript"
+      charset="utf-8"
+      src="third_party/jquery-2.0.3.min.js"
+    ></script>


FritzOnFire · 2022-05-11T11:36:47Z

index.html

+    <div id="column-headings-container"></div>
+    <div id="info-columns-container"></div>
+  </body>
+  <script src="./app.js"></script>


This line needs to remain in your head tag.

FritzOnFire · 2022-05-11T11:37:08Z

index.html

-	<p>Hello</p>
-</body>
-
+  <head>


Please convert this file back to using tabs.

FritzOnFire · 2022-05-11T11:37:41Z

style.css

@@ -0,0 +1,116 @@
+* {
+    margin: 0;


Please convert this file to use tabs

FritzOnFire

Rather never use the ! to indicate that something is not null. It will really bite you in the future and cause a lot of extra work.

FritzOnFire · 2022-05-12T06:55:51Z

app.ts

+    fromNumber = 0;
+};
+
+function checkResponseError(response: Response) {


FritzOnFire · 2022-05-12T09:43:03Z

app.ts

+	})
+		.then(checkResponseError)
+		.then((response: Response) => response.json())
+		.then((data: TemplateStringsArray) => {


Suggested change

.then((data: TemplateStringsArray) => {

.then((data: string[][]) => {

FritzOnFire · 2022-05-12T09:58:52Z

app.ts

+		returnBtn.addEventListener("click", () => {
+			createNavigation();
+			recordCount();
+			resizeScreenData()


Missing ;

FritzOnFire · 2022-05-12T09:59:01Z

app.ts

+			recordCount();
+			resizeScreenData()
+			fromNumber = 0;
+			getRecords(fromNumber, fromNumber + numberOfRows)


Missing ;

FritzOnFire · 2022-05-12T10:00:32Z

app.ts

+			recordCount();
+			resizeScreenData()
+			fromNumber = 0;
+			getRecords(fromNumber, fromNumber + numberOfRows)


You have no guarentee that recordCount will finish before getRecords is called. You should change this to only call getRecords if recordCount has finished.

FritzOnFire · 2022-05-12T10:02:01Z

app.ts

+			nextBtn!.disabled = false;
+			previousBtn!.disabled = false;


How do you know if these two buttons are not null?

FritzOnFire · 2022-05-12T10:02:09Z

app.ts

+				nextBtn!.disabled = true;
+				previousBtn!.disabled = false;


How do you know if these two buttons are not null?

FritzOnFire · 2022-05-12T10:02:14Z

app.ts

+				nextBtn!.disabled = false;
+				previousBtn!.disabled = true;


How do you know if these two buttons are not null?

FritzOnFire · 2022-05-12T10:03:51Z

app.ts

+	})
+		.then(checkResponseError)
+		.then((response: Response) => response.json())
+		.then((data: TemplateStringsArray) => {


Suggested change

.then((data: TemplateStringsArray) => {

.then((data: string[]) => {

FritzOnFire · 2022-05-12T10:06:15Z

app.ts

+function navigationDebounce(func: (argOne: number, argTwo: number) => void, delay: number) {
+	return function (argOne: number, argTwo: number) {
+		clearTimeout(timeout);
+
+		timeout = setTimeout(() => {
+			func(argOne, argTwo);
+		}, delay);
+	};
+}


Please move this into the class. The more things you put in a class the better.

AshtonMar added 11 commits April 12, 2022 12:00

first commit

3d76748

multiple-singular-select-functionality

fc17d76

3rd commit

f1e2d5e

first commit

abf2e25

Todays changes

236ae3e

Todays changes

78d3646

Todays changes

20f8768

Todays changes

25982e1

Coding changes, screen size checks, changed how single records work.

d5a0150

Coding changes, screen size checks, changed how single records work.

27e37ab

Coding changes

8e1c83c

AshtonMar requested review from CelesteNaude, FritzOnFire, anzelIMQS and geraldtivatyi April 26, 2022 13:30

Coding changes

28c0127

anzelIMQS requested changes Apr 28, 2022

View reviewed changes

geraldtivatyi suggested changes Apr 28, 2022

View reviewed changes

CelesteNaude requested changes Apr 28, 2022

View reviewed changes

anzelIMQS requested changes May 3, 2022

View reviewed changes

AshtonMar added 2 commits May 3, 2022 08:47

Commit

c0cc0dd

try catch

0a5e24a

AshtonMar requested review from CelesteNaude, anzelIMQS and geraldtivatyi May 3, 2022 07:04

anzelIMQS requested changes May 3, 2022

View reviewed changes

AshtonMar added 4 commits May 3, 2022 12:43

Recent Changes

22ac146

Recent fixes

d868815

Whitespace server/main.go

a25fa90

Recent Fixes

ed88ede

anzelIMQS requested changes May 5, 2022

View reviewed changes

AshtonMar added 3 commits May 5, 2022 12:04

Recent Commit

fdc8503

main.go spacing

891521b

first commit

9c4f823

FritzOnFire requested changes May 6, 2022

View reviewed changes

AshtonMar added 2 commits May 6, 2022 10:29

test

2240555

first commit

ca85f76

FritzOnFire requested changes May 9, 2022

View reviewed changes

AshtonMar added 5 commits May 9, 2022 14:51

Latest Changes

9c05769

Latest Changes

e991ebf

Latest Changes

b085bdd

adding gitignore file

921241f

Spaces to tabs

a58c56d

FritzOnFire requested changes May 11, 2022

View reviewed changes

Recent file added

19aeeb5

FritzOnFire requested changes May 13, 2022

View reviewed changes

Recent

78f5400

		@@ -0,0 +1,414 @@
		// Get the container from the html where the data will be stored
		let recordNav: any = document.querySelector("#record-navigation-container"); //Navigation area;

		currentPage.innerHTML = "";
		currentPage.innerHTML = currentPage.innerHTML = fromNumber + " / " + toNumber + " " + (Number(numberOfRows) + 1) + " records only.";

		let headingColumns: any = document.querySelector("#column-headings-container"); //Headings;
		let infoColumns: any = document.querySelector("#info-columns-container"); //Information;

		selectionArea.innerHTML = "";
		selectionArea.innerHTML = singleRecordSelection;

		(nextBtn as HTMLButtonElement).disabled = false;
		(previousBtn as HTMLButtonElement).disabled = false;

		(this.nextBtn as HTMLButtonElement).disabled = true;
		(this.previousBtn as HTMLButtonElement).disabled = false;

	.then((data: TemplateStringsArray) => {
	.then((data: string[][]) => {

	.then((data: TemplateStringsArray) => {
	.then((data: string[]) => {

Conversation

AshtonMar commented Apr 12, 2022

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

anzelIMQS left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

anzelIMQS left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

anzelIMQS left a comment