Add basic_search and fix node() for external refs in FunOwlImplementation#878
Open
cmungall wants to merge 1 commit into
Open
Add basic_search and fix node() for external refs in FunOwlImplementation#878cmungall wants to merge 1 commit into
cmungall wants to merge 1 commit into
Conversation
… FunOwlImplementation Implements basic_search() supporting exact, partial, starts-with, and regex matching across labels, identifiers, aliases, and mapped identifiers. Fixes node() to return a stub Node for entities referenced but not defined in the ontology (e.g. external CURIEs), instead of returning None which broke graph visualization output. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
basic_search()onFunOwlImplementation, supporting exact, partial, starts-with, and regex matching across labels, identifiers, aliases, and mapped identifiersnode()to return a stubNodefor entities referenced but not defined in the ontology (e.g. external CURIEs likeGO:0008150in a CL ontology file), instead of returningNonewhich broke graph/viz outputinfo, search, andvizwith OFN inputTest plan
poetry run pytest tests/test_implementations/test_funowl.py::TestFunOwlImplementation::test_basic_searchpoetry run pytest tests/test_implementations/test_funowl.py::TestFunOwlImplementation::test_stub_nodes_for_unresolved_external_referencespoetry run pytest tests/test_cli.py::TestCommandLineInterface::test_funowl_info_search_and_graph_outputs🤖 Generated with Claude Code