Skip to content

IONOS(Movie): Thumbnail: prevent downloading large files from non-loc…#153

Merged
printminion-co merged 1 commit into
ionos-devfrom
mk/dev/fix_video_thumbnail_trafic
Apr 9, 2025
Merged

IONOS(Movie): Thumbnail: prevent downloading large files from non-loc…#153
printminion-co merged 1 commit into
ionos-devfrom
mk/dev/fix_video_thumbnail_trafic

Conversation

@printminion-co

@printminion-co printminion-co commented Apr 8, 2025

Copy link
Copy Markdown

…al storage

can be tested locally with Minio with video files larger than 5Mb with moov atom at the end of the file

Download sample video with missing moov atom at the beginning of the file

wget https://www.sample-videos.com/video321/mp4/720/big_buck_bunny_720p_10mb.mp4

Test

  • Upload file before proposed change. Observe - thumbnail exist. I happens because after the error in log "Movie preview generation failed Output" the whole file is downloaded from S3.
  • Upload file with proposed change.
    • Observe - no thumbnail is generated

PR for NC nextcloud#52079

@tanyaka tanyaka left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review OK.

…al storage

Signed-off-by: Misha M.-Kupriyanov <kupriyanov@strato.de>
@printminion-co printminion-co force-pushed the mk/dev/fix_video_thumbnail_trafic branch from 9131942 to 5545d09 Compare April 9, 2025 15:27
@printminion-co printminion-co merged commit eb90a54 into ionos-dev Apr 9, 2025
@printminion-co printminion-co deleted the mk/dev/fix_video_thumbnail_trafic branch May 20, 2026 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants