chore: bump max-version to 33 (HDNEXT-1606)#165
Open
printminion-co wants to merge 4 commits intomainfrom
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Updates this Nextcloud app’s declared compatibility and development dependencies to support Nextcloud 33, along with a small unit-test adjustment for script registry reset.
Changes:
- Bump Nextcloud
max-versionto33inappinfo/info.xml. - Update dev dependency
nextcloud/ocpto thev33line (and lockfile refresh). - Adjust unit test teardown/setup to reset
OCP\Utilscript state without relying on\OC_Utilglobals.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
appinfo/info.xml |
Extends declared Nextcloud compatibility to max-version 33. |
composer.json |
Bumps nextcloud/ocp dev requirement to v33. |
composer.lock |
Refreshes locked dev dependency metadata for nextcloud/ocp v33. |
tests/Controller/PageControllerTest.php |
Updates test isolation reset logic away from \OC_Util globals. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
max-versionfrom31to33inappinfo/info.xmlnextcloud/ocpfrom^v31.0.6to^v33.0.0incomposer.json^8.2(NC33 minimum)Audit
NC32/33 API audit confirmed no blocking changes:
OC_Helper::humanFileSizeetc. — already usingOCP\Util✅@nextcloud/filesv4 breaking changes — not imported ✅app.php,OC_Util::addScript— not used ✅Jira: HDNEXT-1606