Skip to content

Styling the chat#1

Draft
kingo2157 wants to merge 6 commits intoIRHM:mainfrom
kingo2157:Styling
Draft

Styling the chat#1
kingo2157 wants to merge 6 commits intoIRHM:mainfrom
kingo2157:Styling

Conversation

@kingo2157
Copy link
Contributor

No description provided.

@IRHM IRHM self-requested a review October 10, 2020 16:44
Copy link
Owner

@IRHM IRHM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove the css files and add them to the gitignore. Also remove your settings.json.. that should probably be in your user settings not in the workspace.

Remove main.dev.js as well.

@IRHM IRHM added the enhancement New feature or request label Oct 10, 2020
kingo2157 and others added 3 commits October 11, 2020 22:12
also fix insertAdjacentHTML inserting before div and scroll to bottom of div with a better method
@IRHM
Copy link
Owner

IRHM commented Oct 12, 2020

I added some fixes to your code. Also please don't compile the JS, or if you do make sure you don't commit it by accident.

@IRHM IRHM marked this pull request as draft October 13, 2020 06:23
@IRHM IRHM changed the title Added Styling, dummy div to auto scroll Styling the chat Oct 13, 2020
Copy link
Contributor Author

@kingo2157 kingo2157 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are changes that I have viewed; what does this do?

@kingo2157 kingo2157 marked this pull request as ready for review October 19, 2020 21:07
@kingo2157 kingo2157 requested a review from IRHM October 19, 2020 21:09
@IRHM
Copy link
Owner

IRHM commented Oct 20, 2020

These are changes that I have viewed; what does this do?

If you're talking about what I think you are, nothing. It's just a way to organize which changed files you have looked at.


Are you done styling? If not, keep the pr as a draft.

@IRHM IRHM marked this pull request as draft October 20, 2020 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants