Fix medium/low tests#19
Open
pipliggins wants to merge 7 commits into
Open
Conversation
In most cases, involves adding in housekeeping variables which were missing.
Collaborator
Author
Some questions
|
…edit some docstrings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reviews the test suite written by Tom and classed as medium/low priority. Ideally we want to be running these as well as the critical/high priority tests, as they are designed as a useful tool to reduce mistakes creeping into ARC, so it would be good to get to the point where these are all passing via edits either to ARC or the tests themselves.
So far the 'breaking' change has been to add in the skip-logic fields which were missing from various presets, summarised below.
These are almost exclusively 'housekeeping' variables. If there's a reason some were not included in certain presets (e.g. if there's only 1 or 2 fields you don't want to bother with adding the housekeeping variables to the survey, and BRIDGE can cope with the skip-logic fields being missing) lets discuss here, so we can edit the tests & docs accordingly.
sympt_dailydata,treat_dailydata,imagi_dailydata,imagi_ultrasound,imagi_ultrasound_findi,inter_ivfluidsympt_vomit,sign_dailydata,imagi_ctchest_resultmedi_treatexpo14_ancontreat_otherdemog_calcage_days,sympt_dailydatademog_calcage_days,demog_sex,expo14_yn,preg_pregnant,preg_postpartum,sympt_dailydata,sign_dailydatademog_calcage_days,demog_sexdemog_calcage_days,adsym_vomit,vital_dailydata,vital_o2supp,sympt_dailydata,sympt_vomit,sign_dailydata,treat_dailydata,treat_o2supp,critd_critcare,labs_dailydata,imagi_dailydata,imagi_xray,imagi_xray_result,imagi_ctchest,imagi_ctchest_result,imagi_ultrasound,imagi_ultrasound_findi,test_labtestmethodvital_dailydata,vital_o2supp,sign_dailydata,critd_critcare,labs_dailydatavital_dailydata,vital_o2supp,labs_dailydataOther changes