Release automation#194
Merged
Merged
Conversation
Python instantiates processes differently across platforms. On Linux, processes are instantiated using "fork", whereas on Windows and macOS, processes are instantiated using "spawn". Prior to this commit, multiprocessing failed on Windows and macOS, due to the assumption that processes are always forked (and hence inherit resources from the parent process). The failure was related to the dynamic import of the configuration modules. See https://book-of-gehn.github.io/articles/2022/03/06/Multiprocessing-Spawn-of-Dynamically-Imported-Code.html. This commit re-writes multiprocessing such that processes are spawned on all platforms, which will be the default as of Python 3.14 anyway, see https://docs.python.org/3/library/multiprocessing.html#contexts-and-start-methods.
Parse arguments (kind of test and path to InChI library) directly from the command line. Before this commit, those arguments were configured as TestConfig in dedicated files, which was less flexible and more complex.
Collaborator
fbaensch-beilstein
left a comment
fbaensch-beilstein
left a comment
There was a problem hiding this comment.
Overall looks good to me, would be awesome if we could integrate it for the next release
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements #1.
Have a look at the logs of the CI run on this PR to get an impression of how the release automation builds artifacts for the different platforms.