Revision of refactor_main branch#211
Merged
JanCBrammer merged 7 commits intodevfrom May 6, 2026
Merged
Conversation
JanCBrammer
force-pushed
the
dev
branch
2 times, most recently
from
c43dd48 to
4a81ee7
Compare
nnuk
approved these changes
May 6, 2026
Collaborator
nnuk
left a comment
nnuk
left a comment
There was a problem hiding this comment.
I’ve pulled in your latest changes, and everything is now building and running smoothly on my end. The restructuring around main and the associated system files seems to have resolved the earlier inconsistencies we were encountering with the Visual Studio project setup and source layout.
Thanks for putting in the effort to clean this up 👍.
JanCBrammer
force-pushed
the
refactor_main_revision
branch
from
a29613f to
2c0d6db
Compare
Unit Test Coverage ReportCoverage Regression Summary
Find details on the base coverage at https://iupac-inchi.github.io/InChI/coverage/index.html Find details on this PR's coverage by downloading coverage-reports-25433707179 and opening html/index.html |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As detected by @nnuk, PR #182 has caused a lot of issues, and I am not sure how the CLI (i.e.
inchi-1) version sub-project even managed to compile:MS Visual Studioand/orMS Windowsplatforms at all; some functions specific forMS Windowsplatforms had to be moved back toichimain.c.INCHI-BASE/srcfolder without apparent reason; their corresponding functions have been rewritten again in API files. This is especially conspicuous in the case ofichimain.c, which used to be the starting script for CLI version sub-project until now.ichimain.handichimain.chave almost very little in common, which contributes to issue mentioned in item 2. even more.makefile/makefile32had to be updated with newly added files, which had not been done in PR Refactor main #182.MS Visual Studiosolution/project files have been updated._getch()function platform-specific issues have been resolved.main.chas been renamed toinchi_main_cli.cto indicate that it is the main script for CLI sub-project only.