Open
Conversation
lippserd
requested changes
Aug 22, 2024
Member
lippserd
left a comment
lippserd
left a comment
There was a problem hiding this comment.
There is now a lot of duplicated code for basically doing the same. I think creating the log options and making the actual request to the Kubernetes API could be moved to a function.
Also, It might make sense to only sync previous container logs if it has been restarted since the last sync. We would need Pod.ContainerStatuses[].LastTerminationState for that which is currently not reflected in our Container. Though it makes sense to also synchronize that to the database so feel free to create a PR for this one beforehand.
If I'm not mistaken, logs for terminated containers are not collected at all. There is a started.Bool check somewhere. This should be adjusted as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.