Ensure forward compatibility with ipl by adding return types#460
Open
BastianLedererIcinga wants to merge 4 commits intomainfrom
Open
Ensure forward compatibility with ipl by adding return types#460BastianLedererIcinga wants to merge 4 commits intomainfrom
BastianLedererIcinga wants to merge 4 commits intomainfrom
Conversation
Set the return type to static to ensure compatibility with ipl-orm.
Add types and return statements to ensure compatibility with `RewriteFilterbehavior` of ipl-orm.
Add types and missing return statements for compatibility with ipl-orm.
Add bool return type for forward compatibility with ipl-stdlib
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure compatibility with the upcoming strict type additions in:
Icinga/ipl-orm#158
Icinga/ipl-stdlib#69
Icinga/ipl-html#187