Conversation
Until Icinga Web 2.14.0, Less to CSS compilation was handled by Icinga Web itself, making `wikimedia/less.php` a required dependency. Starting with 2.14.0, Less compilation is provided by `ipl\Web`, which renders this entry unnecessary. Listing the dependency here was already questionable regardless, as `icinga-php-library` has carried `wikimedia/less.php` since version `0.13.0` — roughly three years ago.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Until Icinga Web 2.14.0, Less to CSS compilation was handled by Icinga Web itself, making
wikimedia/less.phpa required dependency. Starting with 2.14.0, Less compilation is provided byipl\Web, which renders this entry unnecessary.Listing the dependency here was already questionable regardless, as
icinga-php-libraryhas carriedwikimedia/less.phpsince version0.13.0— roughly three years ago.closes #98
refs Icinga/ipl-web#365
refs Icinga/icingaweb2#5492