ITL: Network Protocol for all Manubulon SNMP Checks#10791
Open
ITL: Network Protocol for all Manubulon SNMP Checks#10791
Conversation
Add a new snmp_network_protocol custom var to all Manubulon SNMP checks to configure the underlying network protocols. By default, the "snmp-manubulon-command" template, used by all Manubulon SNMP checks, sets the protocol to udp and the version of the IP matching the "snmp_address". In the meantime, the upstream moved to GitHub. This was also reflected in the docs and outdated comments, pointing to outdated versions of the checks, were removed.
Member
Author
|
Just saw that the upstream added this flag in two batches:
I am unsure if my changes would be breaking, e.g., for users of an older version of the plugin. In general, the project seems to became quite slow in the last decade. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a new
snmp_network_protocolcustom var to all Manubulon SNMP checks to configure the underlying network protocols. By default, thesnmp-manubulon-commandtemplate, used by all Manubulon SNMP checks, sets the protocol to udp and the version of the IP matching thesnmp_address.In the meantime, the upstream moved to GitHub. This was also reflected in the docs and outdated comments, pointing to outdated versions of the checks, were removed.
I have tested these changes with the following four hosts.
The
--protocolflag of the executed command contained eitherudp/ipv4orudp/ipv6, matching the expectation reflected in the host name.Fixes #10790.