Skip to content

Fix unstable object order#1039

Open
nilmerg wants to merge 4 commits intomainfrom
fix/unstable-service-order
Open

Fix unstable object order#1039
nilmerg wants to merge 4 commits intomainfrom
fix/unstable-service-order

Conversation

@nilmerg
Copy link
Copy Markdown
Member

@nilmerg nilmerg commented Jul 31, 2024

Services usually have similar (if not equal) names across different hosts. Sorting such after (display_)name, might result in unexpected results depending on the used database backend.

To guarantee a deterministic order we have to use more than a single column if said column isn't variant enough.

@nilmerg nilmerg added bug Something isn't working area/view Affects an entire view labels Jul 31, 2024
@nilmerg nilmerg added this to the 1.2.0 milestone Jul 31, 2024
@cla-bot cla-bot bot added the cla/signed CLA is signed by all contributors of a PR label Jul 31, 2024
@nilmerg
Copy link
Copy Markdown
Member Author

nilmerg commented Jul 31, 2024

Currently not tested on PostgreSQL

@nilmerg nilmerg force-pushed the fix/unstable-service-order branch from c561ad0 to 5f63502 Compare April 1, 2025 14:39
@nilmerg nilmerg changed the title Fix unstable service order Fix unstable object order Apr 1, 2025
@nilmerg nilmerg modified the milestones: 1.2.0, 1.3.0 Jun 5, 2025
@nilmerg
Copy link
Copy Markdown
Member Author

nilmerg commented Jun 5, 2025

We'll need to verify query plans of several backends and versions in order to make sure this has no disadvantages.

@nilmerg nilmerg modified the milestones: 1.3.0, 1.4.0 Nov 6, 2025
@nilmerg nilmerg modified the milestones: 1.4.0, 1.5.0 Mar 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/view Affects an entire view bug Something isn't working cla/signed CLA is signed by all contributors of a PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant