Merged
Conversation
BastianLedererIcinga
force-pushed
the
support-php-8.4/8.5
branch
from
89b5572 to
df87d2b
Compare
sukhwinder33445
previously approved these changes
Dec 5, 2025
Contributor
sukhwinder33445
left a comment
sukhwinder33445
left a comment
There was a problem hiding this comment.
The code looks good, @Jan-Schuppik, please approve it when the UI tests are also fine.
sukhwinder33445
previously approved these changes
Dec 5, 2025
Jan-Schuppik
previously approved these changes
Dec 8, 2025
BastianLedererIcinga
dismissed stale reviews from Jan-Schuppik and sukhwinder33445
via
f835d14
lippserd
requested changes
Jan 15, 2026
BastianLedererIcinga
force-pushed
the
support-php-8.4/8.5
branch
from
f835d14 to
3da67a7
Compare
Member
|
@BastianLedererIcinga Please rebase. |
BastianLedererIcinga
force-pushed
the
support-php-8.4/8.5
branch
from
3da67a7 to
e52cab5
Compare
BastianLedererIcinga
force-pushed
the
support-php-8.4/8.5
branch
from
e52cab5 to
4588690
Compare
Closed
BastianLedererIcinga
force-pushed
the
support-php-8.4/8.5
branch
from
bfa33e3 to
6b83442
Compare
BastianLedererIcinga
force-pushed
the
support-php-8.4/8.5
branch
from
6b83442 to
7771483
Compare
BastianLedererIcinga
force-pushed
the
support-php-8.4/8.5
branch
2 times, most recently
from
05a46a9 to
49d97b4
Compare
BastianLedererIcinga
force-pushed
the
support-php-8.4/8.5
branch
from
49d97b4 to
3caa773
Compare
Since PHP 8.4 implicitly nullable parameter types are deprecated. Normalize scoped PHPDoc for nullable-parameter updates: use `?Type` instead of `Type|null` and remove column alignment. Co-authored-by: "Eric Lippmann <eric.lippmann@icinga.com>"
`ReflectionProperty::setAccessible()` has had no effect since PHP 8.1, as all properties are accessible via reflection by default. The method is deprecated as of PHP 8.5.
Replace deprecated `PDO::MYSQL_*` constant usage with the driver-specific `Pdo\Mysql::ATTR_*` constants introduced in PHP 8.4. This prepares the code for PHP 8.5, where accessing MySQL driver constants through the generic `PDO` class is deprecated. This change requires a compatibility shim on older PHP versions to provide `Pdo\Mysql` for runtimes that do not expose the driver-specific class yet. The shim is provided in `ipl-sql`.
lippserd
force-pushed
the
support-php-8.4/8.5
branch
from
3caa773 to
a99b2ec
Compare
Member
|
@BastianLedererIcinga Please justify a99b2ec. |
BastianLedererIcinga
force-pushed
the
support-php-8.4/8.5
branch
3 times, most recently
from
76f5d63 to
d360924
Compare
Passing `null` as the key to `array_key_exists()` or using it as an array key is deprecated as of PHP 8.5. Co-authored-by: Eric Lippmann <eric.lippmann@icinga.com>
Remove errors no longer reported. Since PHP 7.x is no longer supported, remove the 7.x baseline. It is now no longer necessary to have multiple baseline files.
lippserd
force-pushed
the
support-php-8.4/8.5
branch
from
d360924 to
5053fb3
Compare
lippserd
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PHP 8.4
Migration docs
PHP 8.5
ReflectionProperty::setAccessible()callsPdo\Mysqldriver-specific constantsnullas an array key or as the key toarray_key_exists()Migration docs
resolves #1312
requires Icinga/ipl-sql#99