Fix incorrect start times in the timelines of fixed downtimes#1355
Merged
Fix incorrect start times in the timelines of fixed downtimes#1355
Conversation
nilmerg
requested changes
Apr 8, 2026
Previously fixed downtimes always used `TimeAgo` for the start in the timeline, even when the downtime had not yet started.
BastianLedererIcinga
force-pushed
the
fix/downtime-progress-start
branch
from
53d1dbc to
5434860
Compare
nilmerg
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Downtimecards for fixed downtimes currently always use
TimeAgoto display the start time in the timeline, which is incorrect if the start is in the future, for such casesTimeUntilshould be used instead.I tested the change with the current main of ipl-web and with Icinga/ipl-web#350 and it's dependencies, both worked fine.
resolves: #1353