Use forward compatible Mysql constants of ipl-sql#270
Merged
Conversation
lippserd
requested changes
Mar 25, 2026
Member
lippserd
left a comment
lippserd
left a comment
There was a problem hiding this comment.
Change is missing raise of the Icinga PHP Library requirement in docs. Also, adjust commit title and description to be the same as Icinga/icingaweb2@298f524.
BastianLedererIcinga
force-pushed
the
mysql-constants
branch
from
3baa677 to
eb3c19f
Compare
Replace deprecated `PDO::MYSQL_*` constant usage with the driver-specific `Pdo\Mysql::ATTR_*` constants introduced in PHP 8.4. This prepares the code for PHP 8.5, where accessing MySQL driver constants through the generic `PDO` class is deprecated. This change requires a compatibility shim on older PHP versions to provide `Pdo\Mysql` for runtimes that do not expose the driver-specific class yet. The shim is provided in `ipl-sql`. As a consequence, the required version of the Icinga PHP library has been raised.
BastianLedererIcinga
force-pushed
the
mysql-constants
branch
from
eb3c19f to
1af1e6a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For PHP < 8.4 the constant
Pdo\Mysql::ATTR_INIT_COMMANDis not yet available but its predecessor is deprecated.Instead of using a
version_compareto solve this problem, a forward compatibility shim of ipl-sql can be used to support these versions.requires: Icinga/ipl-sql#99