Open
Conversation
The reason we initially switched to asyncHtmlToPdf was because the headless chrome backend tried to create its own event loop, which caused problems with ipl-scheduler. The new pdfexport module no longer has this behaviour. Therefore asyncHtmlToPdf is no longer required. The method was never actually part of the hook and therefore relied on the fact that pdfexport was the only implementation of PdfexportHook.
Contributor
sukhwinder33445
left a comment
sukhwinder33445
left a comment
There was a problem hiding this comment.
Please adjust the requirements. This PR requires Icinga/icingaweb2#5491, Icinga/icingaweb2#5480 and Icinga/icingaweb2-module-pdfexport#88.
While testing, I noticed that BackendLocator::getFirstSupportedBackend() (introduced with Icinga/icingaweb2-module-pdfexport#88) is called twice, once in Pdfexport::isSupported() and once in Pdfexport::htmlToPdf(). This seems redundant and results in duplicate log entries.
sukhwinder33445
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The reason we initially switched to asyncHtmlToPdf was because the headless chrome backend tried to create its own event loop, which caused problems with ipl-scheduler.
The new pdfexport module no longer has this behavior. Therefore, asyncHtmlToPdf is no longer required.
The method was never actually part of the hook and therefore relied on the fact that pdfexport was the only implementation of
PdfexportHook.requires Icinga/icingaweb2#5491
requires Icinga/icingaweb2#5480
requires Icinga/icingaweb2-module-pdfexport#88