Normalize confirm remove

[martialblog]

This PR normalized the use of the phrase "Confirm Removal" in forms that confirm removal.

It also normalizes the use of the "cancel" icon.

refs #5428

[martialblog]

phpcs fails not due to my code changes. Seems to be the same issue in other PRs Class name "Zend_View_Helper_Util" is not in PascalCase format

[lippserd]

@martialblog Please rebase.

[martialblog]

@lippserd Branch is rebased.

[jrauh01]

Thanks for the PR - overall this looks good! The adjustment of the cancel icon is consistent.

Two things to address:

• Role removal button alignment: The confirmation button is currently right-aligned. It should be left-aligned to stay consistent with the other confirmation buttons.
• Dashboard pane removal: The dashlet removal was updated, but the removal of whole dashboard panes wasn't. That'll need to be covered as well.

[jrauh01]

• Role removal button alignment: The confirmation button is currently right-aligned. It should be left-aligned to stay consistent with the other confirmation buttons.

Did you overlook this one, or are you on it?

[martialblog]

@jrauh01 Not 100% sure if this is the correct way to do it cdc20f5 The RoleForm seems to be different than the other forms.

[jrauh01]

Yes, unfortunately the forms are all implemented slightly different. But The UserForm does set the .icinga-controls class as well, so I think your solution fits well with the existing code.

[jrauh01]

@martialblog I just noticed I overlooked, that the button to remove user groups is right-aligned as well. Your fix won't apply cleanly in this case, and I'm not quite sure if it has to be left-aligned, because of the form description. What do you think about that?

[martialblog]

I'm not a certified UX expert so honestly I can't say. We could also probably change the form description to be an HTML element outside the form and align the button. For me personally it's OK as is and since the description relates to the button it probably best to keep them together e.g. for screenreaders.

[jrauh01]

For me it's fine to keep as is as well.

[jrauh01]

LGTM!