Introduce \Icinga\Application\Hook\Essentials#5474
Open
Conversation
This was referenced Feb 16, 2026
Al2Klimov
force-pushed
the
hookEssentials
branch
from
11371cd to
28b18ff
Compare
Al2Klimov
force-pushed
the
hookEssentials
branch
from
28b18ff to
267c5df
Compare
Al2Klimov
force-pushed
the
hookEssentials
branch
from
a161f42 to
f2bdd99
Compare
Al2Klimov
commented
Feb 18, 2026
Member
Author
Al2Klimov
left a comment
Al2Klimov
left a comment
There was a problem hiding this comment.
Test
- Install Fedora 42
- Apply https://github.com/Al2Klimov/ansible-icinga-fedora
- Downgrade to https://git.icinga.com/packages/icingaweb/-/jobs/817857
- Ensure /icingaweb2/health shows Icinga DB and Redis
- In
/usr/share/icingaweb2/modules/icingadb/run.php, comment out$this->provideHook('health', 'RedisHealth'); - Ensure /icingaweb2/health shows Icinga DB only
- In
/usr/share/icingaweb2/modules/icingadb/run.php, add\Icinga\Module\Icingadb\ProvidedHook\RedisHealth::register(); - Ensure /icingaweb2/health shows Icinga DB and Redis again = it works
Member
Author
|
@lippserd Please have a quick look here. This PR would allow to make
gleich gescheit. |
Al2Klimov
force-pushed
the
hookEssentials
branch
2 times, most recently
from
0fd0f9d to
9b20fcd
Compare
Merged
Al2Klimov
force-pushed
the
hookEssentials
branch
from
9b20fcd to
d955987
Compare
sukhwinder33445
requested changes
Apr 10, 2026
| @@ -0,0 +1,57 @@ | |||
| <?php | |||
| /* Icinga Web 2 | (c) 2026 Icinga GmbH | GPLv2+ */ | |||
Contributor
There was a problem hiding this comment.
Please replace:
Suggested change
| /* Icinga Web 2 | (c) 2026 Icinga GmbH | GPLv2+ */ | |
| // SPDX-FileCopyrightText: 2026 Icinga GmbH <https://icinga.com> | |
| // SPDX-License-Identifier: GPL-3.0-or-later |
| * | ||
| * @return bool | ||
| */ | ||
| public static function registered(): bool |
Contributor
There was a problem hiding this comment.
I would prefer isRegistred as method name.
| } | ||
|
|
||
| /** | ||
| * Return all instances of the hook |
Contributor
There was a problem hiding this comment.
Get all instances of the hook
| abstract protected static function getHookName(): string; | ||
|
|
||
| /** | ||
| * Whether someone registered itself for the hook |
Contributor
There was a problem hiding this comment.
someone? Get whether the hook is registred fits better.
to ease finding usages and to be a good example for future hooks. Same with `register()`, `first()` and `has()`.
…\Essentials` ones
Al2Klimov
force-pushed
the
hookEssentials
branch
from
d955987 to
844af8c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.