Replace incubator module with icinga-php-legacy library#5484
Merged
Conversation
lippserd
force-pushed
the
icinga-php-legacy
branch
from
b97e9d2 to
96afe5d
Compare
Jan-Schuppik
previously approved these changes
Mar 26, 2026
Contributor
Jan-Schuppik
left a comment
Jan-Schuppik
left a comment
There was a problem hiding this comment.
Apart from the usage of Icinga\Application\Libraries, everything works as expected
|
|
||
| use Icinga\Application\ApplicationBootstrap; | ||
| use Icinga\Application\Icinga; | ||
| use Icinga\Application\Libraries; |
Contributor
There was a problem hiding this comment.
Am I missing something here, or is the usage of Icinga\Application\Libraries superfluous
lippserd
force-pushed
the
icinga-php-legacy
branch
from
96afe5d to
675aa67
Compare
The `icinga-php-legacy` library is the successor to the standalone `icingaweb2-module-incubator` module. Modules such as director and vspheredb that still declare `incubator` as a dependency should load without a separate incubator installation once `icinga-php-legacy` is present. `Module::getRequiredLibraries` now maps an `incubator` module requirement to an `icinga-php-legacy` library requirement when that library is available, and `getRequiredModules` drops `incubator` from the list so the dependency check does not fail. `Manager::loadModule` skips calling `register()` for the incubator module under the same condition, folding that guard into the existing `ipl`/`reactbundle` exclusion to avoid a double-registration.
lippserd
force-pushed
the
icinga-php-legacy
branch
from
675aa67 to
9db25df
Compare
Jan-Schuppik
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
icinga-php-legacylibrary is the successor to the standaloneicingaweb2-module-incubatormodule. Modules such as director and vspheredb that still declareincubatoras a dependency should load without a separate incubator installation onceicinga-php-legacyis present.Module::getRequiredLibrariesnow maps anincubatormodule requirement to anicinga-php-legacylibrary requirement when that library is available, andgetRequiredModulesdropsincubatorfrom the list so the dependency check does not fail.Manager::loadModuleskips callingregister()for the incubator module under the same condition, folding that guard into the existingipl/reactbundleexclusion to avoid a double-registration.https://github.com/Icinga/icinga-php-legacy replaces https://github.com/Icinga/icingaweb2-module-incubator.