Conversation
The class was only reachable via `autoload-dev`, so downstream packages had no way to extend or use it in their own test suites. Moving it to `ipl\Html\Test` exposes it through the library's existing autoload entry, allowing consumers to rely on it without adjusting their `composer.json`.
Drop the pre-namespace `PHPUnit_Util_XML` compat shim, which targeted PHPUnit 4.x and has been dead code since the PHP 8.2 requirement was introduced. Add native parameter and return types throughout, and align the `assertHtml` parameter names with the conventional `$expected` / `$actual` pair so the signature reads consistently with PHPUnit's own assertion API.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expose
TestCaseunder theipl\Html\Testnamespace so downstreampackages can extend or use it in their own test suites without
adjusting their
composer.json.Drop the pre-namespace
PHPUnit_Util_XMLcompat shim that targetedPHPUnit 4.x, add native parameter and return types, and align
assertHtml's parameter names with the conventional$expected/$actualpair.