Preserve checked state of disabled checkbox on submit#195
Merged
Conversation
Browsers do not submit `disabled` inputs. Since `CheckboxElement`'s `hidden` fallback element always used the `unchecked` value, a `checked` but `disabled` checkbox would appear `unchecked` on the next submit. Fix `renderUnwrapped()` to use the `checked` value in the `hidden` element when the checkbox is `checked` and `disabled`, preserving its state across submissions.
TheSyscall
approved these changes
Mar 25, 2026
TheSyscall
left a comment
TheSyscall
left a comment
There was a problem hiding this comment.
Works as expected.
Changing the value of the hidden element seems like it could have unintended consequences, but I can't think of any case where it wouldn't work.
Contributor
Author
|
The value of hidden element is only changed, when the checkbox is
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Browsers do not submit
disabledinputs. SinceCheckboxElement'shiddenfallback element always used theuncheckedvalue, acheckedbutdisabledcheckbox would appearuncheckedon the next submit.Fix
renderUnwrapped()to use thecheckedvalue in thehiddenelement when the checkbox ischeckedanddisabled, preserving its state across submissions.fixes #192