Support rich labels in SearchSuggestions#366
Open
BastianLedererIcinga wants to merge 1 commit intomainfrom
Open
Support rich labels in SearchSuggestions#366BastianLedererIcinga wants to merge 1 commit intomainfrom
SearchSuggestions#366BastianLedererIcinga wants to merge 1 commit intomainfrom
Conversation
Allow `ValidHtml` to be passed via the `label-html` key which is then rendered inside a `button` element. css selectors are adjusted to have increased specificity because otherwise the button elements are styled by icingaweb2.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow providers of
SearchSuggestionsto passValidHtmlvia alabel-htmlkey, which is rendered inside abuttonelement.The regular label remains unchanged because it is still used to set the
valueattribute, so if html was included it would end up in the input field of theTermInputwhen the suggestion is selected with the arrow keys.Two css selectors are adjusted to have increased specificity to prevent the buttons from being styled by icingaweb2, when used inside a
.icinga-controlselement.resolve #364