Move search-suggestions outside the TermInput's form#368
Draft
BastianLedererIcinga wants to merge 3 commits intomainfrom
Draft
Move search-suggestions outside the TermInput's form#368BastianLedererIcinga wants to merge 3 commits intomainfrom
search-suggestions outside the TermInput's form#368BastianLedererIcinga wants to merge 3 commits intomainfrom
Conversation
Allow `ValidHtml` to be passed via the `label-html` key which is then rendered inside a `button` element. css selectors are adjusted to have increased specificity because otherwise the button elements are styled by icingaweb2.
Css rules that target forms will no longer style the button elements used in the suggestions and the css hack can be reverted.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moving the
search-suggestionselements outside theTermInput's form ensures the button elements are not styled by css rules that target.icinga-controls button. This way the specificity hack introduced by #366 is no longer necessary and can be reverted.requires Icinga/ipl-html#197
Since
TermInput::onRegisteredis used to add thesearch-suggestionselement, we first need to ensure that it is called when theTermInputis part of a fieldset.