fixes "shake to undo" gesture bug. #64
Open
esemusa wants to merge 1 commit into
Open
Conversation
…iginal position after "undo typing" click
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References Issue #55
The avoidingView was not moving back to the original position after "undo typing" click.
Basically, the problem is after the "undo typing" click the keyboardWillChangeFrameNotification observer will be called three times:
1 time: target to show the keyboard
2 time: target to hide the keyboard
3 time: target to show the keyboard
The third call will be executed bevor the "restore state" animation from the second call is finished. Therefore in the third call, all auto location are still saved in
updatedConstraints&updatedConstraintConstants. So we need to wait for the animation to finish and then calldidChangewith the preserved notification object.