refactor(sample) refactor the sample component#108
Open
desig9stein wants to merge 3 commits into
Open
Conversation
- fix fiter input icon position in none chromium browsers - fix filtering input jumping in firefox
Member
|
@desig9stein , so far I am seeing the following issues: Most grid samples don't show their bottom borders
The fit content implementation seems to work only in FF on Windows and latest ChromeThis is how the first calendar sample looks in FF 152.0.5
But in Edge 150.0.4078.65 it still doesn't work. It seems that the approach might be a bit hit and miss:
But after updating Chrome, the calendar now looks okay there (compared to when I showed it to you) |
Contributor
Author
|
@ChronosSF The shadow cutoff occurs because the new Sample component defaults to 16px of padding around the iframe, and in samples with a hardcoded height, we will see this problem. I can fix this in a few ways: I lean toward Option 1 to keep things clean, but let me know what you think! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Closes: #105
To test you need this branch IgniteUI/igniteui-angular-samples#3996