refactor(sidebar-filter): migrate to ReactiveElement with typed igc API#90
Open
viktorkombov wants to merge 12 commits into
Open
refactor(sidebar-filter): migrate to ReactiveElement with typed igc API#90viktorkombov wants to merge 12 commits into
viktorkombov wants to merge 12 commits into
Conversation
… refresh with hash
…g active item after page load
…niteUI/igniteui-astro-components into vkombov/refactor-sidebar-filter
…omponents into vkombov/refactor-sidebar-filter
rkaraivanov
reviewed
Jun 30, 2026
…omponents into vkombov/refactor-sidebar-filter
Switch the <sidebar-filter> element from ReactiveElement to LitElement and adopt Lit's query decorators, per PR review. - Extend LitElement instead of ReactiveElement: the default render() returns noChange and createRenderRoot() returns `this`, so Astro's SSR light-DOM children are left untouched. - Replace the manual querySelector fields and their connectedCallback assignments with @query/@QueryAll decorators, matching the declaration style used in igniteui-webcomponents (experimental decorators, cache flag on stable single-element queries). - Enable experimentalDecorators and disable useDefineForClassFields in tsconfig so the decorator accessors aren't shadowed by instance fields. - Route the astro:page-load listener through the AbortController signal so every connectedCallback listener is cleaned up in disconnectedCallback.
rkaraivanov
approved these changes
Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
HTMLElement→ReactiveElement: lifecycle callbacks without a render cycle;createRenderRoot()returnsthisto keep children in light DOM.ExpandableEl,FilterInputEl, etc.) withIgcInputComponent,IgcIconButtonComponent,IgcTreeItemComponentfromigniteui-webcomponents.setExpandedStatesetsel.expandeddirectly on items instead of callingigcTree.expand(items)(no-op before the tree's slot registry is ready);ensureActiveAncestorsExpandedandcollectAncestorsuseIgcTreeItemComponent.path;collectGroupDescendantsusesgetChildren({ flatten: true }).registerPageHooks()guard: global module-leveldocument.addEventListenercalls wrapped in a lazy_pageHooksRegisteredguard — safe for multiple instances, clear intent.parseKeys/serializeKeyshelpers: consolidate repeatedsplit('\n').filter(Boolean)and[...keys].join('\n')patterns into two module-level functions.AbortControllerwith{ signal }for all event listener cleanup indisconnectedCallback.