Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
5 changes: 2 additions & 3 deletions .config/dotnet-tools.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,8 @@
"tools": {
"sign": {
"version": "0.9.1-beta.26330.1",
"commands": [
"sign"
]
"commands": ["sign"],
"rollForward": false
}
}
}
341 changes: 341 additions & 0 deletions .editorconfig
Original file line number Diff line number Diff line change
@@ -0,0 +1,341 @@
# Repo-wide coding conventions — https://editorconfig.org
# .NET style rules are enforced at build time via EnforceCodeStyleInBuild
# (see Directory.Build.props). Whitespace formatting is gated in CI via
# dotnet format whitespace . --folder --exclude templates node_modules --verify-no-changes
# NOTE: only use `dotnet format whitespace --folder` in this repo — the full
# `dotnet format` (style/analyzers verbs) corrupts files on multi-targeted
# projects by inserting "Unmerged change from project" conflict markers
# (https://github.com/dotnet/format/issues/1634).
#
# Structure: Visual Studio's generated .editorconfig as the base, with
# repo-specific deltas marked "REPO:" and a commented "future candidates"
# section (aspnetcore-inspired) at the bottom. Keep exactly one severity line
# per rule id — the last assignment silently wins. Careful: some options
# silently ignore a `:severity` suffix; use dotnet_diagnostic lines instead.
root = true

[*]
indent_style = space
insert_final_newline = true
trim_trailing_whitespace = true
max_line_length = 120

[*.{json,yml,yaml}]
indent_size = 2

[*.{xml,config,*proj,props,targets,nuspec,resx,slnx,runsettings}]
indent_size = 2

# C# files
[*.{cs,razor}]
indent_size = 4
tab_width = 4

[*.cs]

#### Core EditorConfig Options ####

# REPO: end_of_line intentionally NOT set (VS default: crlf) — no .gitattributes
# yet, enforcing it would churn line endings; revisit together with a .gitattributes.
# REPO: insert_final_newline = true inherited from [*] (VS default: false).

#### .NET Code Actions ####

# Type members
dotnet_hide_advanced_members = false
dotnet_member_insertion_location = with_other_members_of_the_same_kind
dotnet_property_generation_behavior = prefer_throwing_properties

# Symbol search
dotnet_search_reference_assemblies = true

#### .NET Coding Conventions ####

# Organize usings (remove both for no-sort run https://github.com/dotnet/format/issues/772)
dotnet_separate_import_directive_groups = false
dotnet_sort_system_directives_first = true
file_header_template = unset

# this. and Me. preferences
dotnet_style_qualification_for_event = false
dotnet_style_qualification_for_field = false
dotnet_style_qualification_for_method = false
dotnet_style_qualification_for_property = false

# Language keywords vs BCL types preferences
dotnet_style_predefined_type_for_locals_parameters_members = true
dotnet_style_predefined_type_for_member_access = true

# Parentheses preferences
dotnet_style_parentheses_in_arithmetic_binary_operators = always_for_clarity
dotnet_style_parentheses_in_other_binary_operators = always_for_clarity
dotnet_style_parentheses_in_other_operators = never_if_unnecessary
dotnet_style_parentheses_in_relational_binary_operators = always_for_clarity

# Modifier preferences
dotnet_style_require_accessibility_modifiers = for_non_interface_members

# Expression-level preferences
dotnet_prefer_system_hash_code = true
dotnet_style_coalesce_expression = true
dotnet_style_collection_initializer = true
dotnet_style_explicit_tuple_names = true
dotnet_style_namespace_match_folder = true
dotnet_style_null_propagation = true
dotnet_style_object_initializer = true
dotnet_style_operator_placement_when_wrapping = beginning_of_line
dotnet_style_prefer_auto_properties = true
dotnet_style_prefer_collection_expression = when_types_loosely_match
dotnet_style_prefer_compound_assignment = true
dotnet_style_prefer_conditional_expression_over_assignment = true
dotnet_style_prefer_conditional_expression_over_return = true
dotnet_style_prefer_foreach_explicit_cast_in_source = when_strongly_typed
dotnet_style_prefer_inferred_anonymous_type_member_names = true
dotnet_style_prefer_inferred_tuple_names = true
dotnet_style_prefer_is_null_check_over_reference_equality_method = true
dotnet_style_prefer_non_hidden_explicit_cast_in_source = true
dotnet_style_prefer_simplified_boolean_expressions = true
dotnet_style_prefer_simplified_interpolation = true

# Field preferences
dotnet_style_readonly_field = true

# Parameter preferences
dotnet_code_quality_unused_parameters = all

# Suppression preferences
dotnet_remove_unnecessary_suppression_exclusions = none

# New line preferences
# REPO: VS default allows multiple blank lines; we disallow (IDE2000, gated below).
dotnet_style_allow_multiple_blank_lines_experimental = false
dotnet_style_allow_statement_immediately_after_block_experimental = true

#### C# Coding Conventions ####

# var preferences
# REPO: VS default is false; this codebase uses `var` heavily (aspnetcore also true).
csharp_style_var_elsewhere = true
csharp_style_var_for_built_in_types = true
csharp_style_var_when_type_is_apparent = true

# Expression-bodied members
csharp_style_expression_bodied_accessors = true
csharp_style_expression_bodied_constructors = false
csharp_style_expression_bodied_indexers = true
csharp_style_expression_bodied_lambdas = true
csharp_style_expression_bodied_local_functions = false
csharp_style_expression_bodied_methods = false
csharp_style_expression_bodied_operators = false
csharp_style_expression_bodied_properties = true

# Pattern matching preferences
csharp_style_pattern_matching_over_as_with_null_check = true
csharp_style_pattern_matching_over_is_with_cast_check = true
csharp_style_prefer_extended_property_pattern = true
csharp_style_prefer_not_pattern = true
csharp_style_prefer_pattern_matching = true
csharp_style_prefer_switch_expression = true

# Null-checking preferences
csharp_style_conditional_delegate_call = true

# Modifier preferences
csharp_prefer_static_anonymous_function = true
csharp_prefer_static_local_function = true
csharp_preferred_modifier_order = public,private,protected,internal,file,static,extern,new,virtual,abstract,sealed,override,readonly,unsafe,required,volatile,async
csharp_style_prefer_readonly_struct = true
csharp_style_prefer_readonly_struct_member = true

# Code-block preferences
csharp_prefer_braces = true
csharp_prefer_simple_using_statement = true
csharp_prefer_system_threading_lock = true
# REPO: block_scoped matches the codebase majority incl. generated components
# (aspnetcore uses file_scoped — see future candidates / IDE0161).
csharp_style_namespace_declarations = block_scoped
csharp_style_prefer_method_group_conversion = true
csharp_style_prefer_primary_constructors = true
csharp_style_prefer_simple_property_accessors = true
csharp_style_prefer_top_level_statements = true

# Expression-level preferences
csharp_prefer_simple_default_expression = true
csharp_style_deconstructed_variable_declaration = true
csharp_style_implicit_object_creation_when_type_is_apparent = true
csharp_style_inlined_variable_declaration = true
csharp_style_prefer_implicitly_typed_lambda_expression = true
csharp_style_prefer_index_operator = true
csharp_style_prefer_local_over_anonymous_function = true
csharp_style_prefer_null_check_over_type_check = true
csharp_style_prefer_range_operator = true
csharp_style_prefer_tuple_swap = true
csharp_style_prefer_unbound_generic_type_in_nameof = true
csharp_style_prefer_utf8_string_literals = true
csharp_style_throw_expression = true
csharp_style_unused_value_assignment_preference = discard_variable
csharp_style_unused_value_expression_statement_preference = discard_variable

# 'using' directive preferences
csharp_using_directive_placement = outside_namespace

# New line preferences
csharp_style_allow_blank_line_after_colon_in_constructor_initializer_experimental = true
csharp_style_allow_blank_line_after_token_in_arrow_expression_clause_experimental = true
csharp_style_allow_blank_line_after_token_in_conditional_expression_experimental = true
csharp_style_allow_blank_lines_between_consecutive_braces_experimental = true
csharp_style_allow_embedded_statements_on_same_line_experimental = true

#### C# Formatting Rules ####

# New line preferences
csharp_new_line_before_catch = true
csharp_new_line_before_else = true
csharp_new_line_before_finally = true
csharp_new_line_before_members_in_anonymous_types = true
csharp_new_line_before_members_in_object_initializers = true
csharp_new_line_before_open_brace = all
csharp_new_line_between_query_expression_clauses = true

# Indentation preferences
csharp_indent_block_contents = true
csharp_indent_braces = false
csharp_indent_case_contents = true
csharp_indent_case_contents_when_block = false
csharp_indent_labels = one_less_than_current
csharp_indent_switch_labels = true

# Space preferences
csharp_space_after_cast = false
csharp_space_after_colon_in_inheritance_clause = true
csharp_space_after_comma = true
csharp_space_after_dot = false
csharp_space_after_keywords_in_control_flow_statements = true
csharp_space_after_semicolon_in_for_statement = true
csharp_space_around_binary_operators = before_and_after
csharp_space_around_declaration_statements = false
csharp_space_before_colon_in_inheritance_clause = true
csharp_space_before_comma = false
csharp_space_before_dot = false
csharp_space_before_open_square_brackets = false
csharp_space_before_semicolon_in_for_statement = false
csharp_space_between_empty_square_brackets = false
csharp_space_between_method_call_empty_parameter_list_parentheses = false
csharp_space_between_method_call_name_and_opening_parenthesis = false
csharp_space_between_method_call_parameter_list_parentheses = false
csharp_space_between_method_declaration_empty_parameter_list_parentheses = false
csharp_space_between_method_declaration_name_and_open_parenthesis = false
csharp_space_between_method_declaration_parameter_list_parentheses = false
csharp_space_between_parentheses = false
csharp_space_between_square_brackets = false

# Wrapping preferences
csharp_preserve_single_line_blocks = true
# REPO: VS default is true; false splits `int a; int b;` style one-liners
# (matches aspnetcore and the tested one-time-format baseline).
csharp_preserve_single_line_statements = false

#### Naming styles ####

# Naming rules

dotnet_naming_rule.interface_should_be_begins_with_i.severity = suggestion
dotnet_naming_rule.interface_should_be_begins_with_i.symbols = interface
dotnet_naming_rule.interface_should_be_begins_with_i.style = begins_with_i

dotnet_naming_rule.types_should_be_pascal_case.severity = suggestion
dotnet_naming_rule.types_should_be_pascal_case.symbols = types
dotnet_naming_rule.types_should_be_pascal_case.style = pascal_case

dotnet_naming_rule.non_field_members_should_be_pascal_case.severity = suggestion
dotnet_naming_rule.non_field_members_should_be_pascal_case.symbols = non_field_members
dotnet_naming_rule.non_field_members_should_be_pascal_case.style = pascal_case

# Symbol specifications

dotnet_naming_symbols.interface.applicable_kinds = interface
dotnet_naming_symbols.interface.applicable_accessibilities = public, internal, private, protected, protected_internal, private_protected
dotnet_naming_symbols.interface.required_modifiers =

dotnet_naming_symbols.types.applicable_kinds = class, struct, interface, enum
dotnet_naming_symbols.types.applicable_accessibilities = public, internal, private, protected, protected_internal, private_protected
dotnet_naming_symbols.types.required_modifiers =

dotnet_naming_symbols.non_field_members.applicable_kinds = property, event, method
dotnet_naming_symbols.non_field_members.applicable_accessibilities = public, internal, private, protected, protected_internal, private_protected
dotnet_naming_symbols.non_field_members.required_modifiers =

# Naming styles

dotnet_naming_style.pascal_case.required_prefix =
dotnet_naming_style.pascal_case.required_suffix =
dotnet_naming_style.pascal_case.word_separator =
dotnet_naming_style.pascal_case.capitalization = pascal_case

dotnet_naming_style.begins_with_i.required_prefix = I
dotnet_naming_style.begins_with_i.required_suffix =
dotnet_naming_style.begins_with_i.word_separator =
dotnet_naming_style.begins_with_i.capitalization = pascal_case

#### Enforced severities (the repo gates) ####

# IDE0055: All formatting rules — build warning + fixed by the whitespace gate.
# (aspnetcore keeps this at `suggestion` and relies purely on their CI format
# check; we use `warning` so violations are visible in the IDE/build.)
dotnet_diagnostic.IDE0055.severity = warning

# IDE2000: Disallow multiple blank lines (option set above).
# Reported as a build warning (EnforceCodeStyleInBuild), but NOT auto-fixed by
# `dotnet format whitespace` — only `dotnet format style` (unusable here, see
# header note) or CSharpier can fix it automatically.
dotnet_diagnostic.IDE2000.severity = warning

# IDE0005: Remove unnecessary usings. Only reported during build when the
# project generates an XML docs file; always applied in the IDE.
dotnet_diagnostic.IDE0005.severity = warning

#### Future candidates (aspnetcore-inspired) — enable after the one-time format
#### and a cleanup pass. Most below have NO auto-fix via our safe format
#### command, so enabling them creates manual work; the ones marked [fixer]
#### at least have an IDE code fix. Test-project relaxations can mirror
#### aspnetcore (suggestion severity under a [tests/**.cs] section) when enabled.

## Hygiene / dead code
# dotnet_diagnostic.IDE0011.severity = warning # braces around blocks [fixer]
# dotnet_diagnostic.IDE0035.severity = warning # remove unreachable code [fixer]
# dotnet_diagnostic.IDE0036.severity = warning # modifier order [fixer]
# dotnet_diagnostic.IDE0044.severity = warning # make field readonly [fixer]
# dotnet_diagnostic.IDE0051.severity = warning # unused private members
# dotnet_diagnostic.IDE0059.severity = warning # unnecessary value assignment
# dotnet_diagnostic.IDE0060.severity = warning # unused parameter
# dotnet_diagnostic.IDE0161.severity = warning # file-scoped namespace [fixer] — conflicts with block_scoped choice above

## Correctness (aspnetcore has these at warning; mostly no fixer)
# dotnet_diagnostic.CA2011.severity = warning # avoid infinite recursion
# dotnet_diagnostic.CA2013.severity = warning # no ReferenceEquals on value types
# dotnet_diagnostic.CA2016.severity = warning # forward CancellationToken
# dotnet_diagnostic.CA2200.severity = warning # rethrow preserving stack
# dotnet_diagnostic.CA2201.severity = warning # no reserved exception types
# dotnet_diagnostic.CA2208.severity = warning # instantiate ArgumentException correctly
# dotnet_diagnostic.CA2245.severity = warning # do not assign property to itself

## Performance (aspnetcore CA18xx set; some have fixers, review per-rule)
# dotnet_diagnostic.CA1822.severity = warning # make member static (scope with dotnet_code_quality.CA1822.api_surface = private, internal)
# dotnet_diagnostic.CA1825.severity = warning # avoid zero-length array allocs [fixer]
# dotnet_diagnostic.CA1827.severity = warning # Any() over Count() [fixer]
# dotnet_diagnostic.CA1829.severity = warning # Length/Count over Count() [fixer]
# dotnet_diagnostic.CA1854.severity = warning # TryGetValue over ContainsKey+indexer [fixer]

## Line endings / encoding — pair with a .gitattributes first
# end_of_line = crlf
# charset = utf-8

#### Generated code — keep LAST so it overrides all sections above ####

# Generated TS interop sources (ingested; tab-indented) — leave untouched so
# editors don't churn them on save. Also excluded from Prettier (.prettierignore).
[src/src/ig/**]
indent_style = unset
indent_size = unset
insert_final_newline = unset
trim_trailing_whitespace = unset
14 changes: 14 additions & 0 deletions .git-blame-ignore-revs
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
# Commits listed here are skipped by `git blame` (and GitHub's blame view
# picks this file up automatically at the repo root).
#
# Local setup (one-time, per clone):
# git config blame.ignoreRevsFile .git-blame-ignore-revs
#
# Only full 40-character SHAs are valid; a bad entry makes `git blame` error
# out. Append the SHA in a follow-up commit (the hash is only known after the
# formatting commit is created).

# One-time repo-wide formatting commit (dotnet format whitespace + prettier)
152588b1db59b64bd5249043e870a6db87ed5295
9a14240ce192dcbed48445ab6251ae33c9f53cbb
98dd4eae72d03f6cecb8b22ae1ea7583362c69ee
4 changes: 4 additions & 0 deletions .githooks/pre-commit
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
#!/bin/sh
# Format staged files with Prettier (and run any other lint-staged tasks).
# Configuration lives in package.json under "lint-staged".
exec npx --no-install lint-staged
12 changes: 6 additions & 6 deletions .github/ISSUE_TEMPLATE/config.yml
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
blank_issues_enabled: false
contact_links:
- name: Ask a Question
url: https://github.com/IgniteUI/igniteui-blazor/discussions/new
about: Start a Discussion.
- name: Read the Docs
url: https://www.infragistics.com/products/ignite-ui-blazor/blazor/components/general-getting-started
about: Be sure you've read the docs!
- name: Ask a Question
url: https://github.com/IgniteUI/igniteui-blazor/discussions/new
about: Start a Discussion.
- name: Read the Docs
url: https://www.infragistics.com/products/ignite-ui-blazor/blazor/components/general-getting-started
about: Be sure you've read the docs!
Loading
Loading