Enable back Calendar and Rating Change events + more details on Select issue.#266
Open
MayaKirova wants to merge 1 commit into
Open
Enable back Calendar and Rating Change events + more details on Select issue.#266MayaKirova wants to merge 1 commit into
MayaKirova wants to merge 1 commit into
Conversation
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
|
|
||
| eventMessage = ""; | ||
| var res = await JS.InvokeAsync<object>("triggerEvent", evtName, argDetailToSend); | ||
| var res = await JS.InvokeAsync<object>("triggerEvent", evtName, argDetailToSend, detailType == typeof(DateTime)); |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Lite TestBed’s bulk-automation harness to re-enable Change event validation for IgbCalendar and IgbRating, while documenting why IgbSelect.Change remains excluded due to an unmockable complex event detail type. It improves the fidelity of synthetic event dispatch so these events can be triggered reliably during automated API checks.
Changes:
- Updates synthetic event triggering to support
DateTime-backed details by sending a real JSDateinCustomEvent.detail. - Removes
Changefrom the excluded events list forIgbCalendarandIgbRating, and clarifies the exclusion rationale forIgbSelect.Change. - Extends reflection-based event-detail detection with a calendar-specific
object -> DateTimemapping and adjusts the default sampledoublevalue used for synthetic payloads.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/IgniteUI.Blazor.Lite.TestBed/wwwroot/app.js | Enhances triggerEvent to optionally convert payloads into a JS Date for date-based event details. |
| tests/IgniteUI.Blazor.Lite.TestBed/componentsConfig.json | Re-enables Change event testing for Calendar/Rating; documents Select’s Change exclusion due to complex detail payload. |
| tests/IgniteUI.Blazor.Lite.TestBed/Components/Pages/Home.razor | Passes inferred detail-type info into triggerEvent and updates reflection call signature. |
| tests/IgniteUI.Blazor.Lite.TestBed/Components/Common/ReflectionUtils.cs | Adds calendar-specific detail-type handling and adjusts sample double generation for event/property mocking. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable back Calendar and Rating Change events. Add more details on why Select Change cannot be mocked ATM.
Closes #262