fix(*): Fix ReportValidity/CheckValidity return types.#268
Open
dkamburov wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates several Ignite UI Blazor component wrappers so their ReportValidity*/CheckValidity* methods return the boolean result produced by the underlying DOM reportValidity() / checkValidity() calls, instead of returning void/Task.
Changes:
- Updated
ReportValidityAsync/ReportValidityto returnTask<bool>/boolfor multiple components and convert the JS return value viaReturnToBoolean. - Updated
CheckValidityAsync/CheckValidityto returnTask<bool>/boolfor multiple components and convert the JS return value viaReturnToBoolean. - Aligned the
Selectwrapper’sCheckValidity*methods with the same boolean-return pattern already used forReportValidity*.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/components/Blazor/Textarea.cs | Return bool/Task from reportValidity and checkValidity interop calls. |
| src/components/Blazor/Slider.cs | Return bool/Task from reportValidity and checkValidity interop calls. |
| src/components/Blazor/Select.cs | Return bool/Task from checkValidity interop calls. |
| src/components/Blazor/Rating.cs | Return bool/Task from reportValidity and checkValidity interop calls. |
| src/components/Blazor/InputBase.cs | Return bool/Task from reportValidity and checkValidity interop calls. |
| src/components/Blazor/DateRangePicker.cs | Return bool/Task from reportValidity and checkValidity interop calls. |
| src/components/Blazor/DatePicker.cs | Return bool/Task from reportValidity and checkValidity interop calls. |
| src/components/Blazor/Combo.cs | Return bool/Task from reportValidity and checkValidity interop calls. |
| src/components/Blazor/CheckboxBase.cs | Return bool/Task from reportValidity and checkValidity interop calls. |
Comment on lines
+227
to
+235
| public async Task<bool> ReportValidityAsync() | ||
| { | ||
| await InvokeMethod("reportValidity", new object[] { }, new string[] { }); | ||
| var iv = await InvokeMethod("reportValidity", new object[] { }, new string[] { }); | ||
| return ReturnToBoolean(iv); | ||
| } | ||
| public void ReportValidity() | ||
| public bool ReportValidity() | ||
| { | ||
| InvokeMethodSync("reportValidity", new object[] { }, new string[] { }); | ||
| var iv = InvokeMethodSync("reportValidity", new object[] { }, new string[] { }); | ||
| return ReturnToBoolean(iv); |
Comment on lines
+240
to
+248
| public async Task<bool> CheckValidityAsync() | ||
| { | ||
| await InvokeMethod("checkValidity", new object[] { }, new string[] { }); | ||
| var iv = await InvokeMethod("checkValidity", new object[] { }, new string[] { }); | ||
| return ReturnToBoolean(iv); | ||
| } | ||
| public void CheckValidity() | ||
| public bool CheckValidity() | ||
| { | ||
| InvokeMethodSync("checkValidity", new object[] { }, new string[] { }); | ||
| var iv = InvokeMethodSync("checkValidity", new object[] { }, new string[] { }); | ||
| return ReturnToBoolean(iv); |
Contributor
|
@dkamburov We can also remove the skips in the test for these APIs now: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Motivation / Context
Copy of https://github.com/Infragistics-Developer-Tools/dev-tools/pull/2129
Type of Change (check all that apply):
Component(s) / Area(s) Affected:
How Has This Been Tested?
Test Configuration:
Screenshots / Recordings
Checklist:
README.MDCHANGELOG.MDupdates for newly added functionalityCloses #