ci: Update npm-publish workflow for 1st party actions, permissions and node#1749
ci: Update npm-publish workflow for 1st party actions, permissions and node#1749turbobobbytraykov wants to merge 6 commits into
Conversation
Updated workflow to use newer action versions and added permissions for id-token and contents.
|
coverage: 87.816%. remained the same — btraykov/update-publish-workflow into master |
|
@turbobobbytraykov it'd appear the publish workflow is already updated to actions@6 and node 24 looking at the state in master: igniteui-cli/.github/workflows/npm-publish.yml Lines 15 to 18 in bd0bcea https://github.com/IgniteUI/igniteui-cli/blob/master/.github/workflows/npm-publish.yml Thus the conflicts :) |
Co-authored-by: Damyan Petev <damyanpetev@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Updates the GitHub Actions npm-publish workflow to align with newer CI practices (updated 1st-party actions, explicit permissions, and a newer Node runtime) for publishing packages on release creation.
Changes:
- Adds explicit workflow permissions (
id-token: write,contents: read). - Updates
actions/checkout/actions/setup-nodeaction versions and bumps Node from 20 to 24. - Refactors npm tag selection logic and introduces an MCP package validation step.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
turbobobbytraykov
changed the title
|
And this ended up with no changes left it seems, perhaps the new new thing Copilot noted last? |
| - name: Publish packages | ||
| # use npm run as yarn run changes the registry and publishes to https://registry.yarnpkg.com | ||
| run: npm run deploy ${NPM_TAG} | ||
| run: npm publish --tag ${NPM_TAG} |
|
These changes are irrelevant due to the current state of the branch - it already contains all the relevant changes. Closing this PR. |
Updated workflow to use newer action versions and added permissions for id-token and contents - just like in the master branch
+
updated actions/checkout to v7
+
updated node 20 -> 24
Description
Make sure we are aligned with the current practices that are already applied to the master branch.
Related Issue
N/A
Type of Change
Affected Packages
igniteui-cli(packages/cli)@igniteui/cli-core(packages/core)@igniteui/angular-templates(packages/igx-templates)@igniteui/angular-schematics(packages/ng-schematics)@igniteui/mcp-server(packages/igniteui-mcp)Checklist
npm run test)npm run build)npm run lint)Additional Context
N/A