Get $fish_path from the command line associated with $fish_pid#637
Open
dljsjr wants to merge 1 commit intoIlanCosman:mainfrom
Open
Get $fish_path from the command line associated with $fish_pid#637dljsjr wants to merge 1 commit intoIlanCosman:mainfrom
$fish_path from the command line associated with $fish_pid#637dljsjr wants to merge 1 commit intoIlanCosman:mainfrom
Conversation
This PR retrieves the path to the Fish executable using `ps` and the current `$fish_pid` variable. This can make the generated/`eval`'d `fish_prompt` function more resilient to environments where the `fish` binary is a symlink, and the symlink target moves around. It *may* also help with the fact that `status fish-path` can only report `fish` on OpenBSD, but I don't have any way to test that. The most immediate "downside" here is that it relies using `ps`, which doesn't have a fish built-in fallback; it's unclear to me if that's problematic or not. Resolves: IlanCosman#627
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR retrieves the path to the Fish executable using
psand the current$fish_pidvariable.Motivation and Context
The primary motivation is to make the generated/
eval'dfish_promptfunction more resilient to environments where thefishbinary is a symlink, and the symlink target moves around.It may also help with the fact that
status fish-pathcan only reportfishon OpenBSD, but I don't have any way to test that.The most immediate "downside" here is that it relies on
ps, which doesn't have a fish built-in fallback; it's unclear to me if that's actually problematic in practice or not.Closes #627
How Has This Been Tested