Skip to content

Katrashova branch#72

Open
KseniaKatrashova wants to merge 27 commits into
mainfrom
KatrashovaBranch
Open

Katrashova branch#72
KseniaKatrashova wants to merge 27 commits into
mainfrom
KatrashovaBranch

Conversation

@KseniaKatrashova
Copy link
Copy Markdown
Collaborator

4.5

не могу найти ошибку, подскажите
Traceback (most recent call last):
  File "C:\Users\Евгений\Desktop\git\PythonCourse2.0_August22\Practice\Katrashova\les4.5.py", line 4, in <module>
    c = random.randint(a, b)
NameError: name 'random' is not defined
Copy link
Copy Markdown
Owner

@IlyaOrlov IlyaOrlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Оставил замечания.

Comment thread Practice/Katrashova/les4.5.py Outdated
Comment thread Practice/RybnikovS/Lec 04/Task 03.py Outdated
@@ -1,4 +1,4 @@
s = ""
s = ""
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Лишний пробел закрался.

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Оу, а это вообще левый файл. Стоит сделать git pull origin main

Copy link
Copy Markdown
Owner

@IlyaOrlov IlyaOrlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Остались небольшие замечания.

Comment thread Practice/Katrashova/lesson4/les 4.6.py
Comment thread Practice/Katrashova/lesson4/les4.8.py Outdated
Copy link
Copy Markdown
Owner

@IlyaOrlov IlyaOrlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ОК. Остались вопросы. И надо что-то делать с чужим файлом RybnikovS/Lec 04/Task 03.py (стоит его напрямую из main себе скопировать).

Comment thread Practice/Katrashova/lesson4/les4.7.py Outdated
Copy link
Copy Markdown
Owner

@IlyaOrlov IlyaOrlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Добавил замечания + остались старые вопросы.

Comment thread Practice/Katrashova/lesson5/5.1.py Outdated
Comment thread Practice/esafonova/task5.1.py Outdated
@@ -8,6 +8,6 @@ def sort(arr):
arr[m], arr[i] = arr[i], arr[m]
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ещё один лишний файл появился.

Comment thread Practice/Katrashova/lesson5/5.2.py Outdated
Comment thread Practice/Katrashova/lesson5/5.1.py Outdated
Comment thread Practice/Katrashova/lesson5/5.1.py Outdated
Copy link
Copy Markdown
Owner

@IlyaOrlov IlyaOrlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ОК. Новых замечаний нет, но со старыми надо разобраться.

Copy link
Copy Markdown
Owner

@IlyaOrlov IlyaOrlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Добавил новые замечания. И остались старые.

Comment thread Practice/Katrashova/lesson5/5.1.py Outdated
def show(self):
print(f"Танк {self.name} экипажем {self.crew} человек(а), и массой {self.weight}")

def __lt__(self, other):
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Метод __lt__ должен возвращать True или False, если в задании не указано иное.

Copy link
Copy Markdown
Owner

@IlyaOrlov IlyaOrlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ОК. Остались еще замечания.

Copy link
Copy Markdown
Owner

@IlyaOrlov IlyaOrlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Новых замечаний нет. Но старые нужно исправить!

Copy link
Copy Markdown
Owner

@IlyaOrlov IlyaOrlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Еще осталось замечание по lesson5/5.1.py
И надо еще сделать git pull origin main (при конфликте выбрать изменения с main, не свои).
Потому что левые файлы удалили, но они при мерже в main и там удалятся.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants