Задачи 7.3#171
Open
Dkisunkina wants to merge 5 commits into
Open
Conversation
IlyaOrlov
requested changes
Aug 10, 2023
Owner
IlyaOrlov
left a comment
IlyaOrlov
left a comment
There was a problem hiding this comment.
Есть небольшое предложение по оптимизации.
| i.give_money(money) | ||
| money = int(input("Ведите сумму, которую хотите положить на счёт: ")) | ||
| i.take_money(money) | ||
| if isinstance(i, SecondAtm): |
Owner
There was a problem hiding this comment.
Если добавить в родительский класс метод online с телом pass, то и isinstance проверять не придётся.
IlyaOrlov
requested changes
Aug 11, 2023
Owner
IlyaOrlov
left a comment
IlyaOrlov
left a comment
There was a problem hiding this comment.
Ещё одно маленькое замечание.
| # Функция должна принимать три массива ([1, 2, 3], [4, 5], [6, 7]), а вернуть лишь один | ||
| # # массив ([1, 2, 3, 4, 5, 6, 7]) | ||
|
|
||
| from itertools import chain |
Owner
There was a problem hiding this comment.
Лучше какой-то один вариант импорта оставить: этот или в стр.8
Dkisunkina
force-pushed
the
Kisunkina_branch
branch
from
47fc46b to
919c77d
Compare
IlyaOrlov
requested changes
Aug 13, 2023
Owner
IlyaOrlov
left a comment
IlyaOrlov
left a comment
There was a problem hiding this comment.
Новых замечаний нет. Только старые.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.