RB-10.5 Backport of #1507 #1509
Open
+127
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has been lifted from IECoreArnold, because we now want to provide it in all renderer backends. In IECoreArnold it was described as a "substitutions" API, but I've characterised it as a "render adaptor" API here as it isn't limited to substitutions and we want to make it clear that it applies at render time. There are no Python bindings because doing anything with Python would be a performance issue when translating scenes at scale. Test coverage will be provided by IECoreArnold, IECoreRenderMan etc.
This is critical on Windows CI, because GitHub has just updated the default Python version to 3.12, which no longer includes `distutils`. See actions/runner-images#13468.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we're building Gaffer 1.6 against Cortex 10.5 & 10.6 on CI, we require these API additions on RB-10.5 otherwise Gaffer's
linux-gcc11-platform23CI job will fail to build.