You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@neuroelf, this vulnerability message can be safely ignored because I resolved the issue in other PRs with npm audit, which updated both package.json and package-lock.json. So there is no need for npm audit to run here since the fixes will ultimately be merged into the master branch from those other branches
OK. @danlamanna -- is there a way for me to confirm (other than the page loading) that it actually fires Google-Tag-Manager requests? I used an Chrome incognito tab, and looked at the Network tab of the Inspector window, and only saw the initial loading of the gtm.js script, but then no further requests being fired...?
OK. @danlamanna -- is there a way for me to confirm (other than the page loading) that it actually fires Google-Tag-Manager requests? I used an Chrome incognito tab, and looked at the Network tab of the Inspector window, and only saw the initial loading of the gtm.js script, but then no further requests being fired...?
I don't think this PR is ready for review since it's in draft status. Is that right @EkaterinaPoddubskaya?
Hi @danlamanna and @neuroelf - yes, this PR is still in draft status. It's not possible to see the results in your GA right now because I use my private gtm container to set everything up, test properly and not pollute your GA statistics with test data. When I finish it, I'm going to move these settings to your container and mark this PR ready for review. After you merge it, you'll be able to check it in realtime overview reports
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves issue #119