Skip to content

fix: scope GCP packages to prevent dependency confusion (BRISKET-W103) #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
igoroctaviano merged 2 commits into from
Jun 24, 2026
Merged

fix: scope GCP packages to prevent dependency confusion (BRISKET-W103) #130

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7a6a640
fix: scope GCP packages to prevent dependency confusion (BRISKET-W103)
igoroctaviano Jun 24, 2026
96f4837
chore: pin GCP packages to latest main commits
igoroctaviano Jun 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .npmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
# Dependency confusion mitigation (BRISKET-W103):
# @idc scoped packages are private IDC dependencies installed only from explicit
# Git commit URLs in package.json — never from unscoped public registry names.
# Pin all @idc/* git dependencies to full commit hashes, not branch names.
8 changes: 4 additions & 4 deletions .webpack/rules/transpileJavaScript.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,13 +17,13 @@ function transpileJavaScript(mode) {
// https://github.com/openlayers/openlayers#supported-browsers
// 'ol', --> Should be fine
// Add GCP extensions that need TypeScript transpilation
'ohif-gcp-extension',
'ohif-gcp-mode',
'@idc/gcp-extension',
'@idc/gcp-mode',
])
: excludeNodeModulesExcept([
// Add GCP extensions that need TypeScript transpilation
'ohif-gcp-extension',
'ohif-gcp-mode',
'@idc/gcp-extension',
'@idc/gcp-mode',
]);

return {
Expand Down
2 changes: 1 addition & 1 deletion idc-assets/app-config-template.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ window.config = {
'@ohif/mode-segmentation': {
hide: true,
},
'ohif-gcp-mode': {
'@idc/gcp-mode': {
hide: true,
}
},
Expand Down
4 changes: 2 additions & 2 deletions platform/app/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,8 @@
],
"dependencies": {
"@ohif/extension-idc": "0.0.1",
"ohif-gcp-extension": "https://github.com/ImagingDataCommons/ohif-gcp-extension#main",
"ohif-gcp-mode": "https://github.com/ImagingDataCommons/ohif-gcp-mode#main",
"@idc/gcp-extension": "https://github.com/ImagingDataCommons/ohif-gcp-extension#d006293822c5d1a8c831ac7606373e9c0d4807a1",
"@idc/gcp-mode": "https://github.com/ImagingDataCommons/ohif-gcp-mode#b1aab90176abde2adc5ab9e35d21289936317e0d",
"@babel/runtime": "7.28.2",
"@cornerstonejs/codec-charls": "1.2.3",
"@cornerstonejs/codec-libjpeg-turbo-8bit": "1.2.2",
Expand Down
4 changes: 2 additions & 2 deletions platform/app/pluginConfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@
"packageName": "@ohif/extension-idc"
},
{
"packageName": "ohif-gcp-extension",
"packageName": "@idc/gcp-extension",
"version": "0.0.1"
}
],
Expand Down Expand Up @@ -108,7 +108,7 @@
"version": "3.0.0"
},
{
"packageName": "ohif-gcp-mode",
"packageName": "@idc/gcp-mode",
"version": "0.0.1"
}
],
Expand Down
2 changes: 1 addition & 1 deletion platform/app/public/config/default.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -404,7 +404,7 @@ window.config = {
'@ohif/mode-segmentation': {
hide: true,
},
'ohif-gcp-mode': {
'@idc/gcp-mode': {
hide: true,
}
},
Expand Down
24 changes: 12 additions & 12 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2445,6 +2445,18 @@
resolved "https://registry.yarnpkg.com/@icr/polyseg-wasm/-/polyseg-wasm-0.4.0.tgz#755e23d07c3d8d8fca1113278c803c1ef0185da0"
integrity sha512-3sZmiwG8I0NaqPle0L7+V/ZexiR7IjIUFkUsaOoFI9rNuBGyyMMmxAxnCmqcDFtBDk9h+JEYJf6e3NnqlHi/HQ==

"@idc/gcp-extension@https://github.com/ImagingDataCommons/ohif-gcp-extension#d006293822c5d1a8c831ac7606373e9c0d4807a1":
version "0.0.1"
resolved "https://github.com/ImagingDataCommons/ohif-gcp-extension#d006293822c5d1a8c831ac7606373e9c0d4807a1"
dependencies:
"@babel/runtime" "^7.20.13"

"@idc/gcp-mode@https://github.com/ImagingDataCommons/ohif-gcp-mode#b1aab90176abde2adc5ab9e35d21289936317e0d":
version "0.0.1"
resolved "https://github.com/ImagingDataCommons/ohif-gcp-mode#b1aab90176abde2adc5ab9e35d21289936317e0d"
dependencies:
"@babel/runtime" "^7.20.13"

"@inquirer/ansi@^1.0.0", "@inquirer/ansi@^1.0.2":
version "1.0.2"
resolved "https://registry.yarnpkg.com/@inquirer/ansi/-/ansi-1.0.2.tgz#674a4c4d81ad460695cb2a1fc69d78cd187f337e"
Expand Down Expand Up @@ -14954,18 +14966,6 @@ obuf@^1.0.0, obuf@^1.1.2:
resolved "https://registry.yarnpkg.com/obuf/-/obuf-1.1.2.tgz#09bea3343d41859ebd446292d11c9d4db619084e"
integrity sha512-PX1wu0AmAdPqOL1mWhqmlOd8kOIZQwGZw6rh7uby9fTc5lhaOWFLX3I6R1hrF9k3zUY40e6igsLGkDXK92LJNg==

"ohif-gcp-extension@https://github.com/ImagingDataCommons/ohif-gcp-extension#main":
version "0.0.1"
resolved "https://github.com/ImagingDataCommons/ohif-gcp-extension#5b0f1abd847d531792e340f302e3e9f6eed685ec"
dependencies:
"@babel/runtime" "^7.20.13"

"ohif-gcp-mode@https://github.com/ImagingDataCommons/ohif-gcp-mode#main":
version "0.0.1"
resolved "https://github.com/ImagingDataCommons/ohif-gcp-mode#38ebce6eea27a939442c0847257c0197f5ffd592"
dependencies:
"@babel/runtime" "^7.20.13"

oidc-client-ts@3.3.0:
version "3.3.0"
resolved "https://registry.yarnpkg.com/oidc-client-ts/-/oidc-client-ts-3.3.0.tgz#98a12e643b930825fb141634974e139d804ef972"
Expand Down
Loading