fix: improve overview map sizing and integer viewport dimensions#266
Open
igoroctaviano wants to merge 1 commit into
Open
fix: improve overview map sizing and integer viewport dimensions#266igoroctaviano wants to merge 1 commit into
igoroctaviano wants to merge 1 commit into
Conversation
Size the volume overview mini-map with a minimum height and preferred width so wide/thin slides stay usable, and round non-volume viewport pixel sizes to integers for DICOMweb servers that reject fractional viewport values. Companion to ImagingDataCommons/slim#400.
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
viewportpixel dimensions to integers after applyingresizeFactor, avoiding HTTP 400 from DICOMweb servers (e.g. Google Healthcare) that reject fractional values.Related
Test plan
pnpm testresizeFactorrequests integerviewportdimensions