Skip to content

fix: declare uuid and fraction.js dependencies#396

Merged
igoroctaviano merged 1 commit into
masterfrom
fix/missing-uuid-fraction-js
Jul 9, 2026
Merged

fix: declare uuid and fraction.js dependencies#396
igoroctaviano merged 1 commit into
masterfrom
fix/missing-uuid-fraction-js

Conversation

@igoroctaviano

Copy link
Copy Markdown
Collaborator

Summary

  • Add uuid as a direct dependency (used by Header, Description, Report, and pubSubServiceInterface).
  • Add fraction.js as a devDependency so autoprefixer/postcss-preset-env can resolve it under pnpm's layout.

Without these, pnpm start fails with Can't resolve 'uuid' and Cannot find module 'fraction.js'.

Test plan

  • From a clean install (rm -rf node_modules && pnpm install), run REACT_APP_CONFIG=example pnpm start
  • Confirm the app compiles without uuid / fraction.js module errors
  • Spot-check that CSS (index.css / App.light.less / App.dark.less) still loads

uuid is imported directly but was never listed in package.json, and
fraction.js must be hoisted for autoprefixer under pnpm so CSS builds.
@sonarqubecloud

sonarqubecloud Bot commented Jul 9, 2026

Copy link
Copy Markdown

@deepsource-io

deepsource-io Bot commented Jul 9, 2026

Copy link
Copy Markdown

DeepSource Code Review

We reviewed changes in d177097...60e6e9e on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

PR Report Card

Overall Grade   Security  

Reliability  

Complexity  

Hygiene  

Code Review Summary

Analyzer Status Updated (UTC) Details
JavaScript Jul 9, 2026 8:25p.m. Review ↗

Important

AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.

@github-actions

github-actions Bot commented Jul 9, 2026

Copy link
Copy Markdown

Visit the preview URL for this PR (updated for commit 60e6e9e):

https://idc-external-006--pr396-fix-missing-uuid-fra-wvnpxlaq.web.app

(expires Thu, 16 Jul 2026 20:27:48 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 88aacecd98ba54d2f9c8d201a9444e43d1ad8307

@igoroctaviano
igoroctaviano merged commit ea513cd into master Jul 9, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant