Skip to content

Migrate slide/annotation Menus to antd items API#398

Merged
igoroctaviano merged 2 commits into
masterfrom
fix/antd-menu-items-api
Jul 13, 2026
Merged

Migrate slide/annotation Menus to antd items API#398
igoroctaviano merged 2 commits into
masterfrom
fix/antd-menu-items-api

Conversation

@igoroctaviano

@igoroctaviano igoroctaviano commented Jul 13, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Migrate SlideList / SlideItem and AnnotationGroupList / AnnotationGroupItem from Menu children / Menu.Item to the antd items API.
  • Replace Header notification Badge counts with static count pills so antd Badge → rc-motion does not call deprecated findDOMNode under React Strict Mode (triggered when warnings like the Viv ~4× pyramid note publish to the header debug badge).

Test plan

  • Open a study on the classic viewer; confirm left-rail slide selection still works (thumbnails, series switch).
  • Toggle annotation groups and change color/opacity; confirm display updates.
  • Confirm console no longer shows antd Menu children deprecation for these lists.
  • On /viv/..., trigger a logger warning (e.g. ~4× pyramid) and confirm the debug bug icon shows a green count without a findDOMNode console warning.
  • Open Debug info modal; confirm error/warning count pills still render on collapse panel headers.

Avoid the antd Menu children deprecation warning by building items in the list components instead of wrapping content in Menu.Item.
@deepsource-io

deepsource-io Bot commented Jul 13, 2026

Copy link
Copy Markdown

DeepSource Code Review

We reviewed changes in eda81d2...fa7fa1e on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

PR Report Card

Overall Grade   Security  

Reliability  

Complexity  

Hygiene  

Code Review Summary

Analyzer Status Updated (UTC) Details
JavaScript Jul 13, 2026 11:10p.m. Review ↗

Important

AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.

antd Badge zoom motion uses rc-motion findDOMNode under React Strict Mode; use static count pills for the debug button and modal panels instead.
@github-actions

github-actions Bot commented Jul 13, 2026

Copy link
Copy Markdown

Visit the preview URL for this PR (updated for commit fa7fa1e):

https://idc-external-006--pr398-fix-antd-menu-items-tq6d8ox6.web.app

(expires Mon, 20 Jul 2026 23:12:48 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 88aacecd98ba54d2f9c8d201a9444e43d1ad8307

@sonarqubecloud

Copy link
Copy Markdown

@igoroctaviano
igoroctaviano merged commit 7751f2b into master Jul 13, 2026
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant