Migrate slide/annotation Menus to antd items API#398
Conversation
Avoid the antd Menu children deprecation warning by building items in the list components instead of wrapping content in Menu.Item.
|
|
Overall Grade |
Security Reliability Complexity Hygiene |
Code Review Summary
| Analyzer | Status | Updated (UTC) | Details |
|---|---|---|---|
| JavaScript | Jul 13, 2026 11:10p.m. | Review ↗ |
Important
AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.
antd Badge zoom motion uses rc-motion findDOMNode under React Strict Mode; use static count pills for the debug button and modal panels instead.
|
Visit the preview URL for this PR (updated for commit fa7fa1e): https://idc-external-006--pr398-fix-antd-menu-items-tq6d8ox6.web.app (expires Mon, 20 Jul 2026 23:12:48 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 88aacecd98ba54d2f9c8d201a9444e43d1ad8307 |
|



Summary
SlideList/SlideItemandAnnotationGroupList/AnnotationGroupItemfromMenuchildren /Menu.Itemto the antditemsAPI.Badgecounts with static count pills so antd Badge → rc-motion does not call deprecatedfindDOMNodeunder React Strict Mode (triggered when warnings like the Viv ~4× pyramid note publish to the header debug badge).Test plan
childrendeprecation for these lists./viv/..., trigger a logger warning (e.g. ~4× pyramid) and confirm the debug bug icon shows a green count without afindDOMNodeconsole warning.