Skip to content

Update linearassembler.py#326

Merged
Ben Preston (ben-l-p) merged 1 commit into
ImperialCollegeLondon:mainfrom
rmorenoramos:patch-1
May 28, 2025
Merged

Update linearassembler.py#326
Ben Preston (ben-l-p) merged 1 commit into
ImperialCollegeLondon:mainfrom
rmorenoramos:patch-1

Conversation

@rmorenoramos

@rmorenoramos rmorenoramos commented May 8, 2025

Copy link
Copy Markdown
Contributor

V2.4 breakes the LinearAeroelastic tests, since the solver is not imported. This pull request restores the working environment for linear simulations by importing the correct solver

@rmorenoramos
Update linearassembler.py
d0a2b2e 
V2.4 breakes the LinearAeroelastic tests, since the solver is not imported. This pull request restores the working environment for linear simulations
@ben-l-p

Ben Preston (ben-l-p) commented May 12, 2025

Copy link
Copy Markdown
Collaborator

Thanks for investigating this issue - I will double check that this problem doesn't affect other solvers, and then we can look to merge.

@ben-l-p Ben Preston (ben-l-p) self-assigned this May 18, 2025
@ben-l-p Ben Preston (ben-l-p) self-requested a review May 18, 2025 16:33
ben-l-p
Ben Preston (ben-l-p) approved these changes May 18, 2025
View reviewed changes

@ben-l-p Ben Preston (ben-l-p) left a comment •
edited
Loading

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had some time to check through what went wrong; I removed this import in the previous PR because my IDE mistakenly said it was an unused import, and yet the code still passed tests for me. Thanks for fixing this issue!

@kccwing

kccwing commented May 18, 2025

Copy link
Copy Markdown
Collaborator

btw, test for pypi was cancelled because GitHub deprecated the older ubuntu runner again - this has been addressed in #320 - so feel free to merge this - thanks!

@ben-l-p Ben Preston (ben-l-p) merged commit ca07a63 into ImperialCollegeLondon:main May 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ben-l-p Ben Preston (ben-l-p) ben-l-p approved these changes

Assignees

@ben-l-p Ben Preston (ben-l-p)

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rmorenoramos @ben-l-p @kccwing