Remove requirement for Mayavi for building SHARPy.#333
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #333 +/- ##
==========================================
- Coverage 67.69% 66.40% -1.29%
==========================================
Files 166 148 -18
Lines 26709 27636 +927
==========================================
+ Hits 18081 18353 +272
- Misses 8628 9283 +655 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
isabella586
approved these changes
May 5, 2026
isabella586
left a comment
isabella586
left a comment
Collaborator
There was a problem hiding this comment.
Agree with removing the requirement for it. Changes look fine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mayavi is now considered un-maintained, and as it has again broken the install process I have depreciated it. All core plotting routines (modal, aero grid and beam) no longer depend upon this and should not be affected. There is still some legacy code referring to it - I have changed this code to use local imports to prevent issues at import time.