Skip to content
This repository was archived by the owner on Jun 10, 2019. It is now read-only.

Fix for issue #146#147

Open
kanevbg wants to merge 1 commit intoInchoo:developfrom
kanevbg:issue-146
Open

Fix for issue #146#147
kanevbg wants to merge 1 commit intoInchoo:developfrom
kanevbg:issue-146

Conversation

@kanevbg
Copy link
Copy Markdown

@kanevbg kanevbg commented Jul 13, 2018

No description provided.

@jacquesbh
Copy link
Copy Markdown

SGTM

@jacquesbh
Copy link
Copy Markdown

Actually @kanevbg a better approach could be this instead:

try {
    session_module_name($moduleName);
} catch (\Throwable $e) {}

Copy link
Copy Markdown

@jacquesbh jacquesbh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See previous comment.

Also the update of modman is missing.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants