Design-doc#1
Open
khadijja1 wants to merge 2 commits into
Open
Conversation
…ownership table , known risks(2 known risks) , Defination of done, Public API design sections in design doc
Expanded the technical approach section with detailed methods, results, and recommendations for near-duplicate detection and language contamination detection. Updated evaluation plan and addressed package name conflict and team size reduction issues.
Collaborator
|
Added my Technical Feasibility section (near-duplicate threshold analysis on 20 real RUEmoCorp pairs, langdetect reliability testing on 12 real samples, and scoring formulas for all 5 checks). Also added a third Known Risk based on what I found — langdetect can't reliably detect Roman Urdu at any text length tested (0% correct across 44 detections), which affects check_language_contamination design. Included a proposed mitigation in the risk entry. Reviewed the Problem Statement — looks solid and concrete. Ready for your review on the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds the Design doc with these sections: project summary , problem statement , evaluation plan , module ownership table , known risks(2 known risks) , Defination of done, Public API design sections filled in.
Which module(s) does it touch?
Docs/Design doc
How did you test it?
Manual review
Edge cases handled:
N/A
Checklist: