Conversation
+ change template names
There was a problem hiding this comment.
@nk-radikant Please resolve merge conflicts, and then add a short description of the changes you have made.
# Conflicts: # src/nav-bar/_nav-bar.scss
|
I merged master into this release to get GitHub Actions working - will forward the resulting URL to the designers for feedback |
kaiwerther
added
minor
|
|
Please label PRs directly as release + one of major/minor/patch |
|
DDS-13 + DDS-14 seems to be fixed, I close them. @nk-radikant Can you please describe what the issue was and how you fixed it? It isn't clear at all from the source code changes. |
|
The main changes done in this PR are: what: added header tag for nav-bars what: fixed the ocean borders position for desktop (Extended Level 2, Extended Level 3) and mobile (Default, Extended, Extended Level 2, Extended Level 3) what: divided desktop nav-bar menus into smaller reusable template parts and changed those template names Other than that I fixed font-weight for dropdown hover behaviour, replaced some fixed values in scss with our tokens, and deleted the data-text attribute in the nav-bar links because it got redundant. |
|
Visual changes are fine and approved. |
tishoyanchev
left a comment
tishoyanchev
left a comment
There was a problem hiding this comment.
Navbar overflows on Extended versions.
Please remove the 110px from margin-left on .ifx__nav-link-wrapper.ifx__desktop-show class.
Double check before submitting another PR.
|
|
4 participants
The main changes done in this PR are:
what: added header tag for nav-bars
why: to have more semantically correct nav-bars
what: fixed the ocean borders position for desktop (Extended Level 2, Extended Level 3) and mobile (Default, Extended, Extended Level 2, Extended Level 3)
why: so that it looks like the designers intended in Figma
what: divided desktop nav-bar menus into smaller reusable template parts and changed those template names
why: for a better overview and maintainability
Other than that I fixed font-weight for dropdown hover behaviour, replaced some fixed values in scss with our tokens, and deleted the data-text attribute in the nav-bar links because it got redundant.
📦 Published PR as canary version:
1.3.0--canary.26.f5eb94067647508cd35c5b96e2e19aaa70d87014.0✨ Test out this PR locally via:
npm install @infineon/design-system-bootstrap@1.3.0--canary.26.f5eb94067647508cd35c5b96e2e19aaa70d87014.0 # or yarn add @infineon/design-system-bootstrap@1.3.0--canary.26.f5eb94067647508cd35c5b96e2e19aaa70d87014.0