Core reorg#2
Merged
Merged
Conversation
Move three cross-cutting subpackages into a shared astraflow/core/
namespace to distinguish them from the engine packages (raas,
train_worker, dataflow). Pure rename + mechanical import sweep,
no logic changes:
- astraflow/{config,weight_manager,workflow}/ -> astraflow/core/<same>/
- import paths updated across the package, docs, and AGENTS.md
- new astraflow/core/__init__.py documents the group's role
- astraflow/__init__.py comment clarifies the dataflow re-export
The reorg of workflow/ under core/ added one directory level. Three helpers that compute paths from __file__ still assumed the pre-reorg depth: - _repo_root() in livecodebench_reward.py, human_eval_reward.py, and code_execution_mraas.py used parents[3], which now lands on the package root instead of the repo root; fix to parents[4] - _verifier_script_path() in livecodebench_reward.py and code_execution_mraas.py hardcoded "workflow" path-segments; fix to "core"/"workflow" Symptom: code/livecodebench/human_eval reward subprocesses launched with a non-existent script path, returned rc=2, and the reward fn caught FileNotFoundError and returned [-4]. All rewards came out 0.0, the m-1 filter dropped every rollout group, and the trainer sat at step 0. Other recipes (math, multi-agent, greso, alfworld) weren't affected because they don't go through the subprocess verifier.
The astraEnv/ASearcher/ASearcher/ subtree and astraEnv/ASearcher/agent/ were vendored upstream snapshots that duplicated logic now living in astraflow/core/workflow/impl/asearcher/. Nothing in the live code path (search recipe, examples, in-package workflows, RAG server scripts) loaded them, but their unconditional astraflow imports created a backwards layering edge from astraEnv into astraflow. Kept (verified live via examples/search/ and astraEnv/ASearcher/scripts/): - scripts/ - RAG server launchers - tools/ - local_retrieval_server.py invoked by scripts - utils/ - index_builder.py invoked by build_index.sh - evaluation/ - config_loader imported by tools/search_utils.py - configs/, demo/, docs/, assets/, qa_synthesis/ - user-facing assets astraEnv is now a pure scripts/assets directory with no Python reaching back into astraflow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge: core-reorg → main
Summary
Groups three cross-cutting subpackages under a shared astraflow.core namespace and removes a dead vendored copy of the ASearcher Python tree. No logic changes to live code paths; one
path-relative bug introduced by the move is fixed in the same branch.
Changes
at step 0. Math / multi-agent / greso / alfworld recipes were unaffected (no subprocess verifier).
astraflow imports, creating a backwards layering edge from astraEnv into astraflow.
Risk / compatibility
any in-flight branches before merging.
Test plan