Skip to content

chore: update to work with changes in Core 3.10 release #288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
karel-rehor merged 1 commit into from
Jun 19, 2026
Merged

chore: update to work with changes in Core 3.10 release #288

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Client.Test.Integration/WriteTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,8 @@ public void WritePartialBatchBehaviorByWriteApi(bool useV2Api, bool expectStruct
Assert.That(pwe.LineErrors, Is.Not.Empty);
Assert.That(ae.Message,
Does.Contain("partial write of line protocol occurred")
.Or.Contain("parsing failed for write_lp endpoint"));
.Or.Contain("parsing failed for write_lp endpoint")
.Or.Contain("line protocol parsing error"));
}
else
{
Expand Down
3 changes: 2 additions & 1 deletion Client/Internal/RestClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@
}

if (!string.IsNullOrEmpty(contentType) &&
!contentType.StartsWith("application/json", StringComparison.OrdinalIgnoreCase))

Check warning on line 130 in Client/Internal/RestClient.cs

View workflow job for this annotation

GitHub Actions / CodeQL-Build 

Dereference of a possibly null reference.
{
return ParsedErrorMessage.Empty;
}
Expand Down Expand Up @@ -167,7 +167,7 @@

private static ParsedErrorMessage? ParsePartialWrite(string? topLevelError, JsonElement? data)
{
if (string.IsNullOrEmpty(topLevelError) || !IsPartialWriteError(topLevelError))

Check warning on line 170 in Client/Internal/RestClient.cs

View workflow job for this annotation

GitHub Actions / CodeQL-Build 

Possible null reference argument for parameter 'topLevelError' in 'bool RestClient.IsPartialWriteError(string topLevelError)'.
{
return null;
}
Expand Down Expand Up @@ -248,7 +248,8 @@
private static bool IsPartialWriteError(string topLevelError)
{
return topLevelError.IndexOf("partial write of line protocol occurred", StringComparison.OrdinalIgnoreCase) >= 0 ||
topLevelError.IndexOf("parsing failed for write_lp endpoint", StringComparison.OrdinalIgnoreCase) >= 0;
topLevelError.IndexOf("parsing failed for write_lp endpoint", StringComparison.OrdinalIgnoreCase) >= 0 ||
topLevelError.IndexOf("line protocol parsing error", StringComparison.OrdinalIgnoreCase) >= 0;
}

private static string? CombineMessages(string? topLevelError, string? dataMessage)
Expand Down
Loading