fix: Fix selected settings item in tablet mode#630
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes the “Settings” list item selection in tablet/two-pane mode so it remains selected when navigating to nested Settings sub-screens.
Changes:
- Update selection logic in
MyAccountScreenWrapperto use a predicate-based match for the selected navigation item. - Extend
MyAccountSettingAction.Navigationwith anisSelectedpredicate and adjust theSettingsentry to match nested settings destinations.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| app/src/main/java/com/infomaniak/swisstransfer/ui/screen/main/settings/MyAccountScreenWrapper.kt | Uses the new isSelected(...) predicate to resolve the currently selected settings navigation entry. |
| app/src/main/java/com/infomaniak/swisstransfer/ui/screen/main/settings/MyAccountScreen.kt | Adds an isSelected predicate to navigation actions and updates Settings to be selected across nested settings destinations. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
NicolasBourdin88
approved these changes
Apr 30, 2026
LunarX
force-pushed
the
fix-selected-settings-item
branch
from
9d29c0e to
724f677
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tablet selection did not recognize nested navigations as being part of the "Settings" item